Re: [PATCHv2 09/10] gdb/testsuite: Add missing expected results

Andrew Burgess
2020-09-18T09:53:55Z

I have pushed this patch with a slightly modified commit message.

Thanks,
Andrew

* Andrew Burgess <andrew.burgess@embecosm.com> [2020-08-26 15:49:16 +0100]:

> The tests in this script are driven from two lists of expected
> results, one of the lists is missing some data so DejaGNU ends up
> matching against the empty string (which passes).
>
> This commit adds the missing expected results into the script.
>
> I could rewrite this test to make things more robust, however, a later
> commit is going to completely rewrite this test script, I'm simply
> adding this here so that _before_ the rewrite the test is complete,
> then if anyone ever digs into the history of this test script things
> will make sense (I hope).
>
> gdb/testsuite/ChangeLog:
>
> * gdb.fortran/array-slices.exp: Add missing message data.
> ---
> gdb/testsuite/ChangeLog | 4 ++++
> gdb/testsuite/gdb.fortran/array-slices.exp | 5 ++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.fortran/array-slices.exp b/gdb/testsuite/gdb.fortran/array-slices.exp
> index 8587c51e990..31f95a3668d 100644
> --- a/gdb/testsuite/gdb.fortran/array-slices.exp
> +++ b/gdb/testsuite/gdb.fortran/array-slices.exp
> @@ -53,7 +53,10 @@ set message_strings \
> " = 'array \\(1:5,1:5\\)'" \
> " = 'array \\(1:10:2,1:10:2\\)'" \
> " = 'array \\(1:10:3,1:10:2\\)'" \
> - " = 'array \\(1:10:5,1:10:3\\)'" ]
> + " = 'array \\(1:10:5,1:10:3\\)'" \
> + " = 'other'" \
> + " = 'other \\(-5:0, -2:0\\)'" \
> + " = 'other \\(-5:4:2, -2:7:3\\)'" ]
>
> set i 0
> foreach result $array_contents msg $message_strings {
> --
> 2.25.4
>