From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gErTG/T/sV/VVAAAWB0awg (envelope-from ) for ; Sun, 15 Nov 2020 23:28:36 -0500 Received: by simark.ca (Postfix, from userid 112) id 6A94A1F08B; Sun, 15 Nov 2020 23:28:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1B62B1E58D for ; Sun, 15 Nov 2020 23:28:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C71B9389200A; Mon, 16 Nov 2020 04:28:35 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 57ECA3857C69 for ; Mon, 16 Nov 2020 04:28:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 57ECA3857C69 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3995A116308; Sun, 15 Nov 2020 23:28:33 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id P2T42FOVOhNn; Sun, 15 Nov 2020 23:28:33 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id D233C116303; Sun, 15 Nov 2020 23:28:32 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id 85366A1873; Mon, 16 Nov 2020 08:03:21 +0400 (+04) Date: Mon, 16 Nov 2020 08:03:21 +0400 From: Joel Brobecker To: Simon Marchi Subject: Re: [PATCH 7/9] Add ptype support for DWARF-based fixed-point types Message-ID: <20201116040321.GC609903@adacore.com> References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <1604817017-25807-8-git-send-email-brobecker@adacore.com> <360aa942-16f6-b81d-720e-9d5897f73135@simark.ca> <20201115065749.GE404828@adacore.com> <20201115070900.GF404828@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > My guess is that it works for C just because of this single case in its > type print function: > > https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/c-typeprint.c;h=10631fff9a8006baf885dcd03720074d5f95f8b9;hb=5778e0dd5d7bb872398a136b6504b9b99d5ce434#l1683 > > If it's a matter of just adding this case to the m2 and pascal in their > type print functions, I think it would be nice simply to avoid the > special case in the test. If it's anything more complex than that, then > I agree with you that it's not worth it. It's indeed nicer, but the thing that stopped me is that ultimately it's time spent doing something unlikely to be useful. Even if it is only 10-15 min to make the change, test and submit it, it's still time away from more useful changes. That being said, I think you are actually right with this. Now that I was made to look into it, I think the issue is in the common type printer, and so adding support there would seem logical, considering how I tried to make said support as generic as possible. I will look further into it next weekend. -- Joel