From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QGF6HfdSrF/rNgAAWB0awg (envelope-from ) for ; Wed, 11 Nov 2020 16:09:11 -0500 Received: by simark.ca (Postfix, from userid 112) id 6BF411F08B; Wed, 11 Nov 2020 16:09:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 080B11E552 for ; Wed, 11 Nov 2020 16:09:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A1753851C35; Wed, 11 Nov 2020 21:09:10 +0000 (GMT) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id C99B43851C35 for ; Wed, 11 Nov 2020 21:09:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C99B43851C35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x343.google.com with SMTP id p22so3498451wmg.3 for ; Wed, 11 Nov 2020 13:09:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=od1cVEQEK16OhjRh90qvrLDqklNwUpyRBWNVehXKxik=; b=BD/s5xQ9Ilv1GnGx+B4jnQ6JWksY8icFCbIvKXRiWEpLlasZ5LhXPoVF7dbo+n0rrE 4s6jXpIAE5/gveao4PRrCwYMYgeh40qV3OV1vjlET6OMYoMnVA6JR+hcU+ZIZUisJslw qbgPzC475+eAK8nTD16rse48Q4qVSK4N4MNDTB5IVXg1bTJdfBBW5tGvTGTWLhSRSlmK SR3rGtRAPDlp/86KOhjI4qdL33zLRf675eugOVjBgkbo0NB8o0gRHQXDllRjzRoFejsN eAVqpoCU1G06NhG+bWLPfBy3JBsrahSDV5iO/jQK4wEjPX3H5+lzSZy3s0SzfSHpmwfQ FSkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=od1cVEQEK16OhjRh90qvrLDqklNwUpyRBWNVehXKxik=; b=gbzddGyQ3AVuJeDLUvJdmoxadbs5DKFCxNLUrWQmA3WUF/JxjIYAXouLV1A+XnYtB3 NCgkii+RGH0hFwNEAsfblVLHTviPvGu8qZxfYNZx2uLYdWLxe8p5e46gHRWcs45joXyZ cujxZqOyu6KWI87hJYCXmfSQmUQ9uWvf28NzvhXXkOpaKzdiLc+3oZKsZquo9GVZJ4+z s8dvYlnVO89Xx5+5apx4GPuLRZkJo7qmtUWxy4QeolfZQEWuu3fDrcD+osjMmrT3Bf5e c36fRZs423noLge23vjSShJKvT8hM3EWslaM+3QbDS7gCG8dJEMd3kUPcuvNDKWjXK8N gcLA== X-Gm-Message-State: AOAM530ZCFpE4yi9wB79NMBJW+GqdGmnXkz69I+UGtwyWbFc6eGIEoQC NBQcJJIOYwFSEs0awl1fWLfKS0EbdcZ45w== X-Google-Smtp-Source: ABdhPJwHS9s4SOSQWmqxl+IdFzHC+Ait6ajb8MmvdE0c87qEyY1N8pfOX+K7h2mSro+xTT7eT4PkPA== X-Received: by 2002:a1c:c203:: with SMTP id s3mr6185554wmf.77.1605128946951; Wed, 11 Nov 2020 13:09:06 -0800 (PST) Received: from localhost (host212-140-123-128.range212-140.btcentralplus.com. [212.140.123.128]) by smtp.gmail.com with ESMTPSA id t17sm3756837wmi.3.2020.11.11.13.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 13:09:06 -0800 (PST) Date: Wed, 11 Nov 2020 21:09:05 +0000 From: Andrew Burgess To: Dimitar Dimitrov Subject: Re: [PATCH] sim: pru: Add support for LMBD instruction Message-ID: <20201111210905.GL2729@embecosm.com> References: <20201110191106.6750-1-dimitar@dinux.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110191106.6750-1-dimitar@dinux.eu> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 21:08:50 up 17 days, 12:12, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Dimitar Dimitrov [2020-11-10 21:11:06 +0200]: > Binutils support for LMBD instruction was merged [1]. So add it also > to simulator. > > LMBD instruction does left-most-bit-detection. It returns 32 if > the given bit value is not found in the provided word value. > > [1] https://sourceware.org/pipermail/binutils/2020-October/113901.html > > sim/pru/ChangeLog: > > * pru.h (RS1SEL): New macro. > (RS1_WIDTH): New macro. > * pru.isa: Describe the LMBD instruction. > > sim/testsuite/sim/pru/ChangeLog: > > * lmbd.s: New test. LGTM. Thanks for doing this. Andrew > > Signed-off-by: Dimitar Dimitrov > --- > sim/pru/pru.h | 2 ++ > sim/pru/pru.isa | 15 +++++++++ > sim/testsuite/sim/pru/lmbd.s | 61 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 78 insertions(+) > create mode 100644 sim/testsuite/sim/pru/lmbd.s > > diff --git a/sim/pru/pru.h b/sim/pru/pru.h > index 240fc30010..cbcc3ef9d7 100644 > --- a/sim/pru/pru.h > +++ b/sim/pru/pru.h > @@ -58,6 +58,8 @@ > > #define XBBO_BASEREG (CPU.regs[GET_INSN_FIELD (RS1, inst)]) > > +#define RS1SEL GET_INSN_FIELD (RS1SEL, inst) > +#define RS1_WIDTH regsel_width (RS1SEL) > #define RDSEL GET_INSN_FIELD (RDSEL, inst) > #define RD_WIDTH regsel_width (RDSEL) > #define RD_REGN GET_INSN_FIELD (RD, inst) > diff --git a/sim/pru/pru.isa b/sim/pru/pru.isa > index 050154560b..c7860d0191 100644 > --- a/sim/pru/pru.isa > +++ b/sim/pru/pru.isa > @@ -247,3 +247,18 @@ INSTRUCTION (iloop, > LOOP_IN_PROGRESS = 1; > PC++; > }) > + > +INSTRUCTION (lmbd, > + { > + int lmbd_i; > + > + OP2 = (IO ? IMM8 : RS2); > + > + for (lmbd_i = RS1_WIDTH - 1; lmbd_i >= 0; lmbd_i--) > + { > + if (!(((RS1 >> lmbd_i) ^ OP2) & 1)) > + break; > + } > + RD = (lmbd_i < 0) ? 32 : lmbd_i; > + PC++; > + }) > diff --git a/sim/testsuite/sim/pru/lmbd.s b/sim/testsuite/sim/pru/lmbd.s > new file mode 100644 > index 0000000000..9a9e7827b2 > --- /dev/null > +++ b/sim/testsuite/sim/pru/lmbd.s > @@ -0,0 +1,61 @@ > +# Check that lmbd insn works. > +# mach: pru > + > +# Copyright (C) 2020 Free Software Foundation, Inc. > +# Contributed by Dimitar Dimitrov > +# > +# This file is part of the GNU simulators. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +.include "testutils.inc" > + > + start > + > + ldi32 r14, 0xffffffff > + ldi32 r15, 0x0 > + ldi32 r16, 0x40000000 > + ldi32 r17, 8 > + > + lmbd r0, r14, 0 > + qbne 2f, r0, 32 > + > + lmbd r0, r14, 1 > + qbne 2f, r0, 31 > + > + lmbd r0, r15, 1 > + qbne 2f, r0, 32 > + > + lmbd r0, r15, 0 > + qbne 2f, r0, 31 > + > + lmbd r0, r16, r15 > + qbne 2f, r0, 31 > + > + lmbd r0, r16, 1 > + qbne 2f, r0, 30 > + > + lmbd r0, r14.w1, 1 > + qbne 2f, r0, 15 > + > + lmbd r0, r17.b0, 1 > + qbne 2f, r0, 3 > + > + lmbd r0, r17.b0, r15 > + qbne 2f, r0, 7 > + > + > +1: > + pass > +2: fail > -- > 2.20.1 >