From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MKT1A1luq1+qIQAAWB0awg (envelope-from ) for ; Tue, 10 Nov 2020 23:53:45 -0500 Received: by simark.ca (Postfix, from userid 112) id 0CB121F08B; Tue, 10 Nov 2020 23:53:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BCE311E58E for ; Tue, 10 Nov 2020 23:53:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DFD7398744E; Wed, 11 Nov 2020 04:53:44 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id CFED63892039 for ; Wed, 11 Nov 2020 04:53:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CFED63892039 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B25C111631B; Tue, 10 Nov 2020 23:53:40 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hTLuWOPlxQco; Tue, 10 Nov 2020 23:53:40 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 603E3116308; Tue, 10 Nov 2020 23:53:40 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id C9EFBA17AA; Wed, 11 Nov 2020 08:53:34 +0400 (+04) Date: Wed, 11 Nov 2020 08:53:34 +0400 From: Joel Brobecker To: Simon Marchi Subject: Re: RFA: Add support for DWARF-based fixed point types Message-ID: <20201111045334.GB17366@adacore.com> References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <8ab4e727-51f8-1652-a143-424079ad4ae1@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ab4e727-51f8-1652-a143-424079ad4ae1@simark.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Simon, > I gave some comments that are more on the coding style side of things, > since I am that that familiar with fixed point types. In general it > seemed to make sense. I'm fine with you merging this series, addressing > the comments as you see fit. Thanks a lot for the review! I read through the comments, and from what I could see, I agree with them all. I'll try to have a new version of the series over the weekend. Thanks again! -- Joel