From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WNAyBOF2qV/vbwAAWB0awg (envelope-from ) for ; Mon, 09 Nov 2020 12:05:37 -0500 Received: by simark.ca (Postfix, from userid 112) id 4E4AB1F09E; Mon, 9 Nov 2020 12:05:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1F34A1F086 for ; Mon, 9 Nov 2020 12:05:32 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B86743972C1F; Mon, 9 Nov 2020 17:05:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B86743972C1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1604941531; bh=uhEOOtEsCzf/8/fAtwZmOd7z8l5137zKUO3U+YzHpos=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HXPusI/An6ciTKVzGGcnMBBooNoritRnP/m4eNIM/jhFI8myUKwtxwYZ5WvQringQ 4WJf1rXzspOlN4V4ynecmPX80dLFS9ejCVGshRdW68rsjAPS347IvNFERMKHrGz8Sx B/nWce1EUbj6yHok2/tN12AUl2gIMe2xe6QIzb8U= Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by sourceware.org (Postfix) with ESMTPS id 0B397397280C for ; Mon, 9 Nov 2020 17:05:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0B397397280C Received: by mail-qv1-xf32.google.com with SMTP id dj6so4397215qvb.3 for ; Mon, 09 Nov 2020 09:05:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uhEOOtEsCzf/8/fAtwZmOd7z8l5137zKUO3U+YzHpos=; b=gGHf+wYE/oZKwPVeroCxWulYOP88aMIFevfWy3Fxx3Nr5n/YYvkvtkiv9FQb6yZu4d tWVXYe1TEbiiRAVukwLJwDUURqwC7lmQ59kAgkxhVeqS8bpe7TkWHLA9Hx3KZvQ7ov8w O+OJe3W2zX9ftgDNo6Fk7XjxETBhC1p1J3p6mGcGWy+S4CO+4D9uZoDlE87RszVFqe31 ga+gsKtBpOcZQaAuAZcPmOmUOQ79gOuoHK1gBbkcoRq1asuytbM1Lb2Bv3aYtVFrJ6XK B/BjTW9lOjiNWJK6GuN5c/c6/sAPkU1EKbKcc1HPyAUX/+PV9ATWxWrIsUGBpRkdOV1Q d2cA== X-Gm-Message-State: AOAM530HSHEH9zujMBcoA5sVl5wWIpwAB6QfbswUTNL+C5bKwEiP6qkJ iWdlTh9Fzy9nj5eAME91MzEu65o3r+1owQ== X-Google-Smtp-Source: ABdhPJy8ItYeonTwDyJyP0mSX4EaTmiW/Wv0qRFGaVx3OXQIhf4KAB+Xq0VD1sgiXadQPLZKLKw0Fw== X-Received: by 2002:a0c:b44d:: with SMTP id e13mr15621775qvf.50.1604941528249; Mon, 09 Nov 2020 09:05:28 -0800 (PST) Received: from localhost.localdomain ([2804:7f0:8284:1487:5c3b:b268:ad95:5f37]) by smtp.gmail.com with ESMTPSA id s2sm5948358qtw.44.2020.11.09.09.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 09:05:27 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH v3 21/24] Extend "x" and "print" commands to support memory tagging Date: Mon, 9 Nov 2020 14:04:32 -0300 Message-Id: <20201109170435.15766-22-luis.machado@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201109170435.15766-1-luis.machado@linaro.org> References: <20201109170435.15766-1-luis.machado@linaro.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Extend the "x" and "print" commands to make use of memory tagging functionality, if supported by the architecture. The "print" command will point out any possible tag mismatches it finds when dealing with pointers, in case such a pointer is tagged. No additional modifiers are needed. Suppose we have a pointer "p" with value 0x1234 (logical tag 0x0) and that we have an allocation tag of 0x1 for that particular area of memory. This is the expected output: (gdb) p/x p Logical tag (0x0) does not match the allocation tag (0x1). $1 = 0x1234 The "x" command has a new 'm' modifier that will enable displaying of allocation tags alongside the data dump. It will display one allocation tag per line. AArch64 has a tag granule of 16 bytes, which means we can have one tag for every 16 bytes of memory. In this case, this is what the "x" command will display with the new 'm' modifier: (gdb) x/32bxm p 0x1234: 0x01 0x02 0x00 0x00 0x00 0x00 0x00 0x00 0x123c: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x1244: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x124c: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 (gdb) x/4gxm a 0x1234: 0x0000000000000201 0x0000000000000000 0x1244: 0x0000000000000000 0x0000000000000000 gdb/ChangeLog: YYYY-MM-DD Luis Machado * printcmd.c (decode_format): Handle the 'm' modifier. (do_examine): Display allocation tags when required/supported. (should_validate_memtags): New function. (print_command_1): Display memory tag mismatches. * valprint.h (struct format_data) : New field. --- gdb/printcmd.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++- gdb/valprint.h | 1 + 2 files changed, 83 insertions(+), 1 deletion(-) diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 6949678235..38b51c64ab 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -54,6 +54,7 @@ #include "gdbsupport/byte-vector.h" #include "gdbsupport/gdb_optional.h" #include "gdbsupport/rsp-low.h" +#include "infrun.h" /* For memtag setting. */ /* Chain containing all defined mtag subcommands. */ @@ -210,6 +211,7 @@ decode_format (const char **string_ptr, int oformat, int osize) val.size = '?'; val.count = 1; val.raw = 0; + val.print_tags = false; if (*p == '-') { @@ -232,6 +234,11 @@ decode_format (const char **string_ptr, int oformat, int osize) val.raw = 1; p++; } + else if (*p == 'm') + { + val.print_tags = true; + p++; + } else if (*p >= 'a' && *p <= 'z') val.format = *p++; else @@ -1116,12 +1123,47 @@ do_examine (struct format_data fmt, struct gdbarch *gdbarch, CORE_ADDR addr) need_to_update_next_address = 1; } + /* Whether we need to print the memory tag information for the current + address range. */ + bool print_range_tag = true; + uint32_t gsize = gdbarch_memtag_granule_size (gdbarch); + /* Print as many objects as specified in COUNT, at most maxelts per line, with the address of the next one at the start of each line. */ while (count > 0) { QUIT; + + CORE_ADDR tag_laddr = 0, tag_haddr = 0; + + /* Print the memory tag information if requested. */ + if (fmt.print_tags && print_range_tag && memtag + && target_supports_memory_tagging ()) + { + tag_laddr = align_down (next_address, gsize); + tag_haddr = align_down (next_address + gsize, gsize); + + struct value *v_addr + = value_from_ulongest (builtin_type (gdbarch)->builtin_data_ptr, + tag_laddr); + + if (gdbarch_tagged_address_p (target_gdbarch (), v_addr)) + { + std::string atag = gdbarch_memtag_to_string (gdbarch, v_addr, + tag_allocation); + + if (!atag.empty ()) + { + printf_filtered (_("\n"), + atag.c_str (), + paddress (gdbarch, tag_laddr), + paddress (gdbarch, tag_haddr)); + } + } + print_range_tag = false; + } + if (format == 'i') fputs_filtered (pc_prefix (next_address), gdb_stdout); print_address (next_gdbarch, next_address, gdb_stdout); @@ -1152,6 +1194,11 @@ do_examine (struct format_data fmt, struct gdbarch *gdbarch, CORE_ADDR addr) /* Display any branch delay slots following the final insn. */ if (format == 'i' && count == 1) count += branch_delay_insns; + + /* Update the tag range based on the current address being + processed. */ + if (tag_haddr <= next_address) + print_range_tag = true; } printf_filtered ("\n"); } @@ -1224,6 +1271,26 @@ print_value (value *val, const value_print_options &opts) annotate_value_history_end (); } +/* Returns true if memory tags should be validated. False otherwise. */ + +static bool +should_validate_memtags (struct value *value) +{ + if (memtag && target_supports_memory_tagging () + && gdbarch_tagged_address_p (target_gdbarch (), value)) + { + gdb_assert (value && value_type (value)); + + enum type_code code = value_type (value)->code (); + + return (code == TYPE_CODE_PTR + || code == TYPE_CODE_REF + || code == TYPE_CODE_METHODPTR + || code == TYPE_CODE_MEMBERPTR); + } + return false; +} + /* Helper for parsing arguments for print_command_1. */ static struct value * @@ -1259,7 +1326,21 @@ print_command_1 (const char *args, int voidprint) if (voidprint || (val && value_type (val) && value_type (val)->code () != TYPE_CODE_VOID)) - print_value (val, print_opts); + { + /* If memory tagging validation is on, check if the tag is valid. */ + if (should_validate_memtags (val) + && gdbarch_memtag_mismatch_p (target_gdbarch (), val)) + { + std::string ltag = gdbarch_memtag_to_string (target_gdbarch (), + val, tag_logical); + std::string atag = gdbarch_memtag_to_string (target_gdbarch (), + val, tag_allocation); + printf_filtered (_("Logical tag (%s) does not match the " + "allocation tag (%s).\n"), + ltag.c_str (), atag.c_str ()); + } + print_value (val, print_opts); + } } /* See valprint.h. */ diff --git a/gdb/valprint.h b/gdb/valprint.h index ef9ebfa84f..fca58ad084 100644 --- a/gdb/valprint.h +++ b/gdb/valprint.h @@ -255,6 +255,7 @@ struct format_data int count; char format; char size; + bool print_tags; /* True if the value should be printed raw -- that is, bypassing python-based formatters. */ -- 2.17.1