From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xaK6OdLen19nCgAAWB0awg (envelope-from ) for ; Mon, 02 Nov 2020 05:26:26 -0500 Received: by simark.ca (Postfix, from userid 112) id DF7121F08B; Mon, 2 Nov 2020 05:26:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DE2E01E58F for ; Mon, 2 Nov 2020 05:26:25 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93E42384BC3C; Mon, 2 Nov 2020 10:26:25 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id B96343846027 for ; Mon, 2 Nov 2020 10:26:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B96343846027 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B5A51AC2E for ; Mon, 2 Nov 2020 10:26:21 +0000 (UTC) Date: Mon, 2 Nov 2020 11:26:20 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Remove .debug_line.dwo from gdb.dwarf2/fission-multi-cu.S Message-ID: <20201102102618.GA24817@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, Consider test-case gdb.dwarf2/fission-multi-cu.exp. It produces an executable fission-multi-cu and a dwo file fission-multi-cu.dwo. The file fission-multi-cu.dwo contains a .debug_line.dwo section, which according to the DWARF v5 standard is a "specialized line number table" for type units in the .debug_info.dwo section, and contains only the directory and filename lists. When reading the actual .debug_line.dwo section using readelf -w, we get: ... The Directory Table is empty. The File Name Table is empty. No Line Number Statements. ... So, the section does not contain any actual information. Furthermore, no information is required because the .debug_line.dwo section does not contain any type units. This is confirmed by: - re-doing the commands listed at the start of fission-multi-cu.S, which were used as starting point for fission-multi-cu.S, and - compiling the fission-multi-cu{1,2}.c files with clang -flto -g -gsplit-dwarf In both cases, no .debug_line.dwo section is generated. Remove the .debug_line.dwo section, to make it fit how split dwarf is actually generated by clang. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Remove .debug_line.dwo from gdb.dwarf2/fission-multi-cu.S gdb/testsuite/ChangeLog: 2020-11-02 Tom de Vries * gdb.dwarf2/fission-multi-cu.S: Remove .debug_line.dwo section. --- gdb/testsuite/gdb.dwarf2/fission-multi-cu.S | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/gdb/testsuite/gdb.dwarf2/fission-multi-cu.S b/gdb/testsuite/gdb.dwarf2/fission-multi-cu.S index 171fa7158d..cb021d5011 100644 --- a/gdb/testsuite/gdb.dwarf2/fission-multi-cu.S +++ b/gdb/testsuite/gdb.dwarf2/fission-multi-cu.S @@ -311,20 +311,6 @@ main: # @main .byte 0 # EOM(1) .byte 0 # EOM(2) .byte 0 # EOM(3) - .section .debug_line.dwo,"",@progbits -.Ltmp4: - .long (.Ltmp5-.Ltmp4)-4 - .short 2 - .long (.Ltmp6-.Ltmp4)-10 - .byte 1 - .byte 1 - .byte -5 - .byte 14 - .byte 1 - .byte 0 - .byte 0 -.Ltmp6: -.Ltmp5: .section .debug_addr,"",@progbits .quad .Lfunc_begin0 .quad .Lfunc_begin1