From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Fix DUPLICATEs in gdb.threads/tls.exp
Date: Thu, 29 Oct 2020 07:56:13 +0100 [thread overview]
Message-ID: <20201029065611.GA8542@delia> (raw)
Hi,
With test-case gdb.threads/tls.exp, we get these:
...
DUPLICATE: gdb.threads/tls.exp: selected thread: 4
DUPLICATE: gdb.threads/tls.exp: selected thread: 2
DUPLICATE: gdb.threads/tls.exp: selected thread: 3
...
Fix these using with_test_prefix.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix DUPLICATEs in gdb.threads/tls.exp
gdb/testsuite/ChangeLog:
2020-10-29 Tom de Vries <tdevries@suse.de>
* gdb.threads/tls.exp: Fix DUPLICATEs.
---
gdb/testsuite/gdb.threads/tls.exp | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.threads/tls.exp b/gdb/testsuite/gdb.threads/tls.exp
index 8147a6c132..77916e758d 100644
--- a/gdb/testsuite/gdb.threads/tls.exp
+++ b/gdb/testsuite/gdb.threads/tls.exp
@@ -127,7 +127,9 @@ proc check_thread_stack {number spin_threads spin_threads_level} {
upvar $spin_threads tarr
upvar $spin_threads_level tarrl
- select_thread $number
+ with_test_prefix "thread stack" {
+ select_thread $number
+ }
send_gdb "where\n"
gdb_expect {
-re ".*(\[0-9\]+)\[ \t\]+$hex in spin \\(vp=(0x\[0-9a-f\]+).*\r\n$gdb_prompt $" {
@@ -257,7 +259,10 @@ set thrs_in_spin 0
foreach i [array names spin_threads] {
if {$spin_threads($i) == 1} {
incr thrs_in_spin
- select_thread $i
+
+ with_test_prefix "spin_threads" {
+ select_thread $i
+ }
set level $spin_threads_level($i)
# We expect to be in sem_wait, but if the thread has not yet
# been scheduled, we might be in sem_post still. We could be at
reply other threads:[~2020-10-29 6:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029065611.GA8542@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox