From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Fix gdb.dwarf2/dw2-error.exp with -readnow
Date: Wed, 28 Oct 2020 21:07:25 +0100 [thread overview]
Message-ID: <20201028200724.GA27811@delia> (raw)
Hi,
With test-case gdb.dwarf2/dw2-error.exp and target board readnow, we get:
...
FAIL: gdb.dwarf2/dw2-error.exp: break -q main
...
In the normal case, after running into the dwarf error, the minimal symbols
are still available, but with -readnow this is not the case.
Mark the FAIL as KFAIL.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix gdb.dwarf2/dw2-error.exp with -readnow
gdb/testsuite/ChangeLog:
2020-10-28 Tom de Vries <tdevries@suse.de>
* gdb.dwarf2/dw2-error.exp: Mark failure break in main as known with
-readnow.
---
gdb/testsuite/gdb.dwarf2/dw2-error.exp | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-error.exp b/gdb/testsuite/gdb.dwarf2/dw2-error.exp
index e698752212..345cc11709 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-error.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-error.exp
@@ -44,5 +44,14 @@ gdb_test "file $binfile" \
{Reading symbols.*Dwarf Error: wrong version in compilation unit header \(is 153, should be 2, 3, 4 or 5\).*} \
"file $testfile"
+# We can't use proc readnow, because the PR makes it return 0.
+gdb_test_multiple "maint print objfiles $binfile" "" {
+ -re "^maint print objfiles \[^\r\n\]*\r\n$gdb_prompt $" {
+ setup_kfail "gdb/26797" *-*-*
+ }
+ -re -wrap "" {
+ }
+}
+
# Now check that we can still break given the minimal symbol.
gdb_test "break -q main" "Breakpoint $decimal.*"
next reply other threads:[~2020-10-28 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 20:07 Tom de Vries [this message]
2020-10-30 18:16 ` Tom Tromey
2020-10-30 19:48 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028200724.GA27811@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox