RE: [PATCH v2 4/4] gdb/mi: add a '--force-condition' flag to the '-break-insert' cmd

Aktemur, Tankut Baris via Gdb-patches
2021-04-08T15:12:31Z

On Thursday, April 8, 2021 5:07 PM, Eli Zaretskii wrote:
> > Date: Thu, 8 Apr 2021 16:22:39 +0200
> > From: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
> >
> > diff --git a/gdb/NEWS b/gdb/NEWS
> > index 6cf76a14317..66f9d756fc4 100644
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -31,6 +31,14 @@
> > equivalent of the CLI's "break -qualified" and "dprintf
> > -qualified".
> >
> > + ** '-break-insert --force-condition' and '-dprintf-insert --force-condition'
> > +
> > + The MI -break-insert and -dprintf-insert commands now support a
> > + '--force-condition' flag to forcibly define a condition even when
> > + the condition is invalid at all locations of the breakpoint. This
> > + is equivalent to the '-force-condition' flag of the CLI's "break"
> > + command.
> > +
> > * GDB now supports core file debugging for x86_64 Cygwin programs.
>
> This part is OK.
>
> > Breakpoint @var{number} will stop the program only if the condition in
> > @var{expr} is true. The condition becomes part of the
> > @samp{-break-list} output (see the description of the @samp{-break-list}
> > -command below).
> > +command below). If the @samp{-force} flag is passed, the condition
> > +is forcibly defined even when it is invalid for all locations of
> > +Breakpoint @var{number}.
> ^^^^^^^^^^
> "Breakpoint" should not be capitalized here.

I'll fix this on my local branch.

> Thanks.

Thanks,
-Baris

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928