From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rDu/Mo6cmF8mUgAAWB0awg (envelope-from ) for ; Tue, 27 Oct 2020 18:17:50 -0400 Received: by simark.ca (Postfix, from userid 112) id C3C821EFBB; Tue, 27 Oct 2020 18:17:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 133231E590 for ; Tue, 27 Oct 2020 18:17:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 937D13959CBB; Tue, 27 Oct 2020 22:17:49 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id C62BF3851C09 for ; Tue, 27 Oct 2020 22:17:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C62BF3851C09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 262C9AC2F for ; Tue, 27 Oct 2020 22:17:46 +0000 (UTC) Date: Tue, 27 Oct 2020 23:17:43 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.cp/psymtab-parameter.exp with -readnow Message-ID: <20201027221741.GA23287@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, When running test-case gdb.cp/psymtab-parameter.exp with target board readnow, we run into: ... FAIL: gdb.cp/psymtab-parameter.exp: maintenance info symtabs ... The FAIL is expected, as mentioned in the comment: ... # The goal is to keep the CU (Compilation Unit) unexpanded. It would be # rather XFAIL than FAIL here. For example -readnow breaks it. gdb_test_no_output "maintenance info symtabs" ... Fix the FAIL by skipping the command for -readnow. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.cp/psymtab-parameter.exp with -readnow gdb/testsuite/ChangeLog: 2020-10-27 Tom de Vries * gdb.cp/psymtab-parameter.exp: Don't expect unexpanded CU for -readnow. --- gdb/testsuite/gdb.cp/psymtab-parameter.exp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.cp/psymtab-parameter.exp b/gdb/testsuite/gdb.cp/psymtab-parameter.exp index 825e3f4a61..4253cf59ad 100644 --- a/gdb/testsuite/gdb.cp/psymtab-parameter.exp +++ b/gdb/testsuite/gdb.cp/psymtab-parameter.exp @@ -27,9 +27,10 @@ clean_restart $testfile.x # As `main' is not present GDB fails to find the proper inferior language. gdb_test_no_output "set language c++" -# The goal is to keep the CU (Compilation Unit) unexpanded. It would be rather -# XFAIL than FAIL here. For example -readnow breaks it. -gdb_test_no_output "maintenance info symtabs" +if { ![readnow] } { + # Check that the the CU (Compilation Unit) is unexpanded. + gdb_test_no_output "maintenance info symtabs" +} # GDB has shown only the `long func()' ELF symbol before, not the DWARF # symbol