From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /oegKI4jl1/nKAAAWB0awg (envelope-from ) for ; Mon, 26 Oct 2020 15:29:18 -0400 Received: by simark.ca (Postfix, from userid 112) id 968C51F08D; Mon, 26 Oct 2020 15:29:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 94B841E590 for ; Mon, 26 Oct 2020 15:29:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28B773857831; Mon, 26 Oct 2020 19:29:17 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 4297A3857831 for ; Mon, 26 Oct 2020 19:29:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4297A3857831 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3B023AE6E for ; Mon, 26 Oct 2020 19:29:13 +0000 (UTC) Date: Mon, 26 Oct 2020 20:29:11 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/symtab] Read CU base address for enqueued CU Message-ID: <20201026192910.GA3049@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, Consider the test-case contained in this patch. It consists of two CUs: - cu1, containing a DW_TAG_variable DIE foo - cu2, containing a DW_TAG_base_type DIE int where the variable foo has type int, in other words, there's an inter-CU reference. When expanding the symtab for cu1, expansion of the symtab for cu2 is enqueued, and later processed by process_full_comp_unit. However, processing of .debug_ranges fails because the range is specified relative to a base address which is considered not to be present because !cu->base_address.has_value (), and we run into this case in dwarf2_ranges_process: ... if (!base.has_value ()) { /* We have no valid base address for the ranges data. */ complaint (_("Invalid .debug_ranges data (no base address)")); return 0; } ... Fix this in process_full_comp_unit by setting cu->base_address. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/symtab] Read CU base address for enqueued CU gdb/ChangeLog: 2020-10-26 Tom de Vries * dwarf2/read.c (process_full_comp_unit): Call dwarf2_find_base_address. gdb/testsuite/ChangeLog: 2020-10-26 Tom de Vries * gdb.dwarf2/enqueued-cu-base-addr.exp: New file. --- gdb/dwarf2/read.c | 2 + gdb/testsuite/gdb.dwarf2/enqueued-cu-base-addr.exp | 112 +++++++++++++++++++++ 2 files changed, 114 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 436a116dc8..e1c528f44d 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -9929,6 +9929,8 @@ process_full_comp_unit (dwarf2_cu *cu, enum language pretend_language) cu->language = pretend_language; cu->language_defn = language_def (cu->language); + dwarf2_find_base_address (cu->dies, cu); + /* Do line number decoding in read_file_scope () */ process_die (cu->dies, cu); diff --git a/gdb/testsuite/gdb.dwarf2/enqueued-cu-base-addr.exp b/gdb/testsuite/gdb.dwarf2/enqueued-cu-base-addr.exp new file mode 100644 index 0000000000..77fe6ff5e9 --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/enqueued-cu-base-addr.exp @@ -0,0 +1,112 @@ +# Copyright 2020 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check whether .debug_ranges is correctly read in during symtab expansion. + +load_lib dwarf.exp + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +}; + +standard_testfile main.c .S + +set executable ${testfile} +set asm_file [standard_output_file ${srcfile2}] + +# We need to know the size of integer types in order to write some of the +# debugging info we'd like to generate. +if [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] { + return -1 +} + +# Create the DWARF. +Dwarf::assemble $asm_file { + global srcdir subdir srcfile + + declare_labels int_label + declare_labels ranges_label + + set main_func \ + [function_range main [list ${srcdir}/${subdir}/$srcfile]] + + cu {} { + compile_unit { + {language @DW_LANG_C_plus_plus} + {name "cu1"} + } { + DW_TAG_variable { + {name foo} + {type :$int_label} + {const_value 1 DW_FORM_sdata} + } + } + } + + cu {} { + compile_unit { + {language @DW_LANG_C_plus_plus} + {name "cu2"} + {ranges ${ranges_label} sec_offset} + {low_pc {[lindex $main_func 0]}} + } { + int_label: base_type { + {byte_size 4 udata} + {encoding @DW_ATE_signed} + {name int} + } + } + } + + ranges {is_64 [is_64_target]} { + ranges_label: sequence { + {range 0 [lindex $main_func 1]} + } + } +} + +if { [prepare_for_testing "failed to prepare" ${testfile} \ + [list $srcfile $asm_file] {nodebug}] } { + return -1 +} + +clean_restart ${binfile} + +# Expand cu1. This will enqueue cu2. +gdb_test "ptype foo" "type = int" + +# Now check that cu2 has an address range starting at main. +set cu2_blockvector_re \ + [multi_line \ + "Symtab for file cu2 at $hex" \ + "Read from object file \[^\r\n\]*" \ + "Language: c\\+\\+" \ + "" \ + "Blockvector:" \ + "" \ + "block #000, \[^\r\n\]* in ($hex)..$hex" \ + ".*"] +gdb_test_multiple "maint print symbols -objfile $binfile" "CU addr found" { + -re -wrap $cu2_blockvector_re { + set addr $expect_out(1,string) + if { $addr eq "0x0" } { + fail "$gdb_test_name (Found 0x0)" + } else { + gdb_test "info symbol $addr" "main in section .*" \ + $gdb_test_name + } + } +}