From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GQOLC3Ogll+9GQAAWB0awg (envelope-from ) for ; Mon, 26 Oct 2020 06:09:55 -0400 Received: by simark.ca (Postfix, from userid 112) id 22B131F08D; Mon, 26 Oct 2020 06:09:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F4C51E590 for ; Mon, 26 Oct 2020 06:09:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B9E59388A43A; Mon, 26 Oct 2020 10:09:53 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 7A626386F47E for ; Mon, 26 Oct 2020 10:09:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7A626386F47E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 92BA8AD2C for ; Mon, 26 Oct 2020 10:09:50 +0000 (UTC) Date: Mon, 26 Oct 2020 11:09:35 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Add missing ranges base in dw2-objfile-overlap-*.S Message-ID: <20201026100934.GA17834@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, When doing a gdb testsuite run with this trigger patch: ... @@ -14454,6 +14454,7 @@ dwarf2_ranges_process if (!base.has_value ()) { + gdb_assert (false); /* We have no valid base address for the ranges data. */ complaint (_("Invalid .debug_ranges data (no base address)")); ... we run into the assert with test-case gdb.dwarf2/dw2-objfile-overlap.exp. Fix this by adding the missing .debug_ranges base in gdb.dwarf2/dw2-objfile-overlap-*.S. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Add missing ranges base in dw2-objfile-overlap-*.S gdb/testsuite/ChangeLog: 2020-10-26 Tom de Vries * gdb.dwarf2/dw2-objfile-overlap-inner.S: Specify default base address for CU. * gdb.dwarf2/dw2-objfile-overlap-outer.S: Same. --- gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-inner.S | 3 +++ gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-outer.S | 3 +++ 2 files changed, 6 insertions(+) diff --git a/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-inner.S b/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-inner.S index e895929532..dd4d5b0eb9 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-inner.S +++ b/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-inner.S @@ -42,6 +42,7 @@ inner: /* CU die */ .uleb128 1 /* Abbrev: DW_TAG_compile_unit */ .4byte .Lline1_begin /* DW_AT_stmt_list */ + .4byte 0 /* DW_AT_low_pc */ .4byte .Ldebug_ranges /* DW_AT_ranges */ .ascii "inner.c\0" /* DW_AT_name */ .ascii "/tmp\0" /* DW_AT_comp_dir */ @@ -77,6 +78,8 @@ inner: .byte 1 /* has_children */ .uleb128 0x10 /* DW_AT_stmt_list */ .uleb128 0x6 /* DW_FORM_data4 */ + .uleb128 0x11 /* DW_AT_low_pc */ + .uleb128 0x1 /* DW_FORM_addr */ .uleb128 0x55 /* DW_AT_ranges */ .uleb128 0x6 /* DW_FORM_data4 */ .uleb128 0x3 /* DW_AT_name */ diff --git a/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-outer.S b/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-outer.S index 9fa578db8a..75efa01400 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-outer.S +++ b/gdb/testsuite/gdb.dwarf2/dw2-objfile-overlap-outer.S @@ -55,6 +55,7 @@ outer_after: /* CU die */ .uleb128 1 /* Abbrev: DW_TAG_compile_unit */ .4byte .Lline1_begin /* DW_AT_stmt_list */ + .4byte 0 /* DW_AT_low_pc */ .4byte .Ldebug_ranges /* DW_AT_ranges */ .ascii "outer.c\0" /* DW_AT_name */ .ascii "/tmp\0" /* DW_AT_comp_dir */ @@ -101,6 +102,8 @@ outer_after: .byte 1 /* has_children */ .uleb128 0x10 /* DW_AT_stmt_list */ .uleb128 0x6 /* DW_FORM_data4 */ + .uleb128 0x11 /* DW_AT_low_pc */ + .uleb128 0x1 /* DW_FORM_addr */ .uleb128 0x55 /* DW_AT_ranges */ .uleb128 0x6 /* DW_FORM_data4 */ .uleb128 0x3 /* DW_AT_name */