From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ILYGCu7kkV9pSAAAWB0awg (envelope-from ) for ; Thu, 22 Oct 2020 16:00:46 -0400 Received: by simark.ca (Postfix, from userid 112) id A68241E89B; Thu, 22 Oct 2020 16:00:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B316F1E552 for ; Thu, 22 Oct 2020 16:00:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2B213987492; Thu, 22 Oct 2020 20:00:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2B213987492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1603396841; bh=kGuDUD0rBes9Ll5v4MDMAmdi3jikjbUaVPKOOsuJWmw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GoT5Pi3aIqDO2OVC1P61AikgyFkBzKhkaorju8t/iRJ9zvZBgST2hzYm3wWKSJqbb /8XyoKlbHEoPr5vx1k3PcTimcpNcWJyElYpO6v/botqRGA9dIgjehLLQEqqAyHl+D6 KH4KHfqg47m2bTcbOcO98aj8MZMnE2873LPnvNIo= Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id 8FEE339874D6 for ; Thu, 22 Oct 2020 20:00:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8FEE339874D6 Received: by mail-qk1-x729.google.com with SMTP id a23so3053785qkg.13 for ; Thu, 22 Oct 2020 13:00:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kGuDUD0rBes9Ll5v4MDMAmdi3jikjbUaVPKOOsuJWmw=; b=UUy+WHqTuqPfUOn+JJbi9qE8x06Qn8DpUFCmx7uR1N3/TpCIG9p0XRQ94+WiZMyigS K7nueV2ScgEzzeybMTfQrXEMRGedFEAT8DXoBOKJGtlW6EWeUkWs6GP1yP1N+Rl5DM/s 8o1rirOonGsjmLqtPX+uKqir13ZVu3Pouu2HAWhBurfWXanmQw7qIkfLxCBGqJuEmRQF ku8Lm3nxHkH87syjw88VvA0NDFM+qJ4UUyoiRUn8sFVeyDtta2MbXv4o4PWzWgiJgvZD 2tyrfnzx5fmZoCmRekl8EHfR/mcCcqA5dqYZjbN2li7zzF2pEoZHxMNg4wrlDBDQ/jqf 9fWg== X-Gm-Message-State: AOAM5316b6RTMjlOB2O19Ay1eoLKgUjV07Knn7yFcsFkTP1FRrna30nD Mdly3EdxqyrKym3HLsHW2aExOyemuGTIJQ== X-Google-Smtp-Source: ABdhPJxd9hB0zky+5t4yZMSvXbmcF1H/nmAg6aFyw1HEChUDyApTfNBqVSogtIWLoAUCbl90hlnHcQ== X-Received: by 2002:a05:620a:69c:: with SMTP id f28mr4504386qkh.437.1603396838864; Thu, 22 Oct 2020 13:00:38 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:8284:1487:b9b1:f72a:8f1:600]) by smtp.gmail.com with ESMTPSA id a21sm1711208qkk.98.2020.10.22.13.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 13:00:38 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH v2 06/24] Unit tests for gdbserver memory tagging remote packets Date: Thu, 22 Oct 2020 16:59:56 -0300 Message-Id: <20201022200014.5189-7-luis.machado@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201022200014.5189-1-luis.machado@linaro.org> References: <20201022200014.5189-1-luis.machado@linaro.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Updates on v2: - Update unit tests to cope with additional tag type field in the remote packets. -- Add some unit testing to exercise the functions handling the qMemTags and QMemTags packets as well as feature support. gdbserver/ChangeLog: YYYY-MM-DD Luis Machado * server.cc (test_memory_tagging_functions): New function. (captured_main): Register test_memory_tagging_functions. --- gdbserver/server.cc | 100 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 100 insertions(+) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 0c845be4af..3e85d1abd5 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -3647,6 +3647,103 @@ detach_or_kill_for_exit_cleanup () } } +#if GDB_SELF_TEST + +namespace selftests { + +static void +test_memory_tagging_functions (void) +{ + /* Setup testing. */ + gdb::char_vector packet; + gdb::byte_vector tags, bv; + std::string expected; + packet.resize (32000); + CORE_ADDR addr; + size_t len; + int type; + + /* Test parsing a qMemTags request. */ + + /* Invalid request, addr len and type unchanged. */ + addr = 0xff; + len = 255; + type = 255; + strcpy (packet.data (), "qMemTags_wrong:0,0:0"); + SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len, &type) != 0); + SELF_CHECK (addr == 0xff && len == 255 && type == 255); + + /* Valid request, addr, len and type updated. */ + addr = 0xff; + len = 255; + type = 255; + strcpy (packet.data (), "qMemTags:0,0:0"); + SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len, &type) == 0); + SELF_CHECK (addr == 0 && len == 0 && type == 0); + + /* Valid request, addr, len and type updated. */ + addr = 0; + len = 0; + type = 0; + strcpy (packet.data (), "qMemTags:deadbeef,ff:5"); + SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len, &type) == 0); + SELF_CHECK (addr == 0xdeadbeef && len == 255 && type == 5); + + /* Test creating a qMemTags reply. */ + + /* Non-empty tag data. */ + bv.resize (0); + + for (int i = 0; i < 5; i++) + bv.push_back (i); + + expected = "m0001020304"; + SELF_CHECK (create_fmemtags_reply (packet.data (), bv) == 0); + SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0); + + /* Empty tag data (error). */ + bv.clear (); + SELF_CHECK (create_fmemtags_reply (packet.data (), bv) != 0); + + /* Test parsing a QMemTags request. */ + + /* Invalid request and non-empty tag data: addr, len, type and tags + unchanged. */ + addr = 0xff; + len = 255; + type = 255; + tags.resize (5); + strcpy (packet.data (), "QMemTags_wrong:0,0:0:0001020304"); + SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags, + &type) != 0); + SELF_CHECK (addr == 0xff && len == 255 && type == 255 && tags.size () == 5); + + /* Valid request and empty tag data: addr, len, type and tags updated. */ + addr = 0xff; + len = 255; + type = 255; + tags.resize (5); + strcpy (packet.data (), "QMemTags:0,0:0:"); + SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags, + &type) == 0); + SELF_CHECK (addr == 0 && len == 0 && type == 0 && tags.size () == 0); + + /* Valid request and non-empty tag data: addr, len, type and tags updated. */ + addr = 0; + len = 0; + type = 0; + tags.resize (0); + strcpy (packet.data (), + "QMemTags:deadbeef,ff:5:0001020304"); + SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags, + &type) == 0); + SELF_CHECK (addr == 0xdeadbeef && len == 255 && type == 5 + && tags.size () == 5); +} + +} // namespace selftests +#endif /* GDB_SELF_TEST */ + /* Main function. This is called by the real "main" function, wrapped in a TRY_CATCH that handles any uncaught exceptions. */ @@ -3664,6 +3761,9 @@ captured_main (int argc, char *argv[]) bool selftest = false; #if GDB_SELF_TEST std::vector selftest_filters; + + selftests::register_test ("remote_memory_tagging", + selftests::test_memory_tagging_functions); #endif current_directory = getcwd (NULL, 0); -- 2.17.1