From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sFL/LzDlkV9pSAAAWB0awg (envelope-from ) for ; Thu, 22 Oct 2020 16:01:52 -0400 Received: by simark.ca (Postfix, from userid 112) id BD7B11EFC9; Thu, 22 Oct 2020 16:01:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 56F9B1E552 for ; Thu, 22 Oct 2020 16:01:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 04F653987492; Thu, 22 Oct 2020 20:01:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 04F653987492 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1603396908; bh=wf96bpoYNxFwTzap0xRDruCTM9egxlaRjhD/9JNYsQ4=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AnWbHVEKVN/GZbSDEuoZ0caClv5qX8dgVOG7TCsTmbshWIml+RvXElNGP9P5lwpgo 1F/qz3dEEJ1YSMAdY6is8UrgW1HyA9DFIZ3k87Ax1qQyr6DhuDma1QRhwMOWsH+qoG jcnSaVJQCe+pife/d4EEzbBvvs/Zx0r85Tcg2YNU= Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id 6E2693987535 for ; Thu, 22 Oct 2020 20:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6E2693987535 Received: by mail-qk1-x744.google.com with SMTP id z6so3095856qkz.4 for ; Thu, 22 Oct 2020 13:01:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wf96bpoYNxFwTzap0xRDruCTM9egxlaRjhD/9JNYsQ4=; b=BFpval1jbg8VxsKtwEj+3uL1+FR+7z0Ldeb8BtFAuXzk9lbP16jDe4u/mcaXr8+lTx VYKgcSycG2LkITe4yK6Kh/i6deYklfKHLk2PlPcpCUMPhQMeGdgzNP0UWebfDwDMvjdZ HYt6tGyd7NQ6zDeZMWOieio9mmKXgHocFO0MbHkOFal0nZNz5iQLIALGnv9J7axa4ECL CUuJtcOYzZ5s+lh9BzoqqFEflAWPBC16IPqqw3AhERXXSZ5GLAb6gULg8tzKSWOnhXgf pEh7WYjFlO3jMEuGv4qG8rurQwIkjqQ0dI18OmSuD90dzyAYDAubagK5n4qIQJbE09sK k5xA== X-Gm-Message-State: AOAM5307+cfH5Bp8A+GUcjs530jifFuOTeCCvXVleqr380hmrCQqHLrY syVF6+mOoz2BxrNTEPrp4sRRdjZ/w432Bw== X-Google-Smtp-Source: ABdhPJylxCYyOEFh38H2oO9MxkKbAooJX41DcxPn0aAovyfSrXYvmU/CJNkNycUlZNp/zwhZhrcV+A== X-Received: by 2002:a37:a045:: with SMTP id j66mr4337733qke.305.1603396904713; Thu, 22 Oct 2020 13:01:44 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:8284:1487:b9b1:f72a:8f1:600]) by smtp.gmail.com with ESMTPSA id a21sm1711208qkk.98.2020.10.22.13.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 13:01:44 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH v2 16/24] AArch64: Report tag violation error information Date: Thu, 22 Oct 2020 17:00:06 -0300 Message-Id: <20201022200014.5189-17-luis.machado@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201022200014.5189-1-luis.machado@linaro.org> References: <20201022200014.5189-1-luis.machado@linaro.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Whenever a memory tag violation occurs, we get a SIGSEGV. Additional information can be obtained through the siginfo data structure. For AArch64 the Linux kernel may expose the fault address and tag information, if we have a synchronous event. Otherwise there is no fault address available. gdb/ChangeLog: YYYY-MM-DD Luis Machado * aarch64-linux-tdep.c (aarch64_linux_report_signal_info): New function. (aarch64_linux_init_abi): Register aarch64_linux_report_signal_info as the report_signal_info hook. * arch/aarch64-linux.h (SEGV_MTEAERR): Define. (SEGV_MTESERR): Define. --- gdb/aarch64-linux-tdep.c | 64 ++++++++++++++++++++++++++++++++++++ gdb/arch/aarch64-mte-linux.h | 6 ++++ 2 files changed, 70 insertions(+) diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 7ae41fc098..0084717c0e 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -1626,6 +1626,67 @@ aarch64_linux_memtag_to_string (struct gdbarch *gdbarch, return string_printf ("0x%s", phex_nz (tag, sizeof (tag))); } +/* AArch64 Linux implementation of the report_signal_info gdbarch + hook. Displays information about possible memory tag violations. */ + +static void +aarch64_linux_report_signal_info (struct gdbarch *gdbarch, + struct ui_out *uiout, + enum gdb_signal siggnal) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + + if (!tdep->has_mte () || siggnal != GDB_SIGNAL_SEGV) + return; + + CORE_ADDR fault_addr = 0; + long si_code = 0; + + try + { + /* Sigcode tells us if the segfault is actually a memory tag + violation. */ + si_code = parse_and_eval_long ("$_siginfo.si_code\n"); + + fault_addr + = parse_and_eval_long ("$_siginfo._sifields._sigfault.si_addr"); + } + catch (const gdb_exception &exception) + { + return; + } + + /* If this is not a memory tag violation, just return. */ + if (si_code != SEGV_MTEAERR && si_code != SEGV_MTESERR) + return; + + uiout->text ("\n"); + + uiout->field_string ("sigcode-meaning", _("Memory tag violation")); + + /* For synchronous faults, show additional information. */ + if (si_code == SEGV_MTESERR) + { + uiout->text (_(" while accessing address ")); + uiout->field_core_addr ("fault-addr", gdbarch, fault_addr); + uiout->text ("\n"); + + CORE_ADDR atag; + if (aarch64_linux_get_atag (fault_addr, &atag) != 0) + uiout->text (_("Allocation tag unavailable")); + else + { + uiout->text (_("Allocation tag ")); + uiout->field_core_addr ("allocation-tag", gdbarch, atag); + } + } + else + { + uiout->text ("\n"); + uiout->text (_("Fault address unavailable")); + } +} + static void aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { @@ -1706,6 +1767,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) /* Register a hook for converting a memory tag to a string. */ set_gdbarch_memtag_to_string (gdbarch, aarch64_linux_memtag_to_string); + + set_gdbarch_report_signal_info (gdbarch, + aarch64_linux_report_signal_info); } /* Initialize the aarch64_linux_record_tdep. */ diff --git a/gdb/arch/aarch64-mte-linux.h b/gdb/arch/aarch64-mte-linux.h index 5c5783f28b..a5a980ed49 100644 --- a/gdb/arch/aarch64-mte-linux.h +++ b/gdb/arch/aarch64-mte-linux.h @@ -35,6 +35,12 @@ #define MTE_LOGICAL_TAG_START_BIT 56 #define MTE_LOGICAL_MAX_VALUE 0xf +/* Memory tagging definitions. */ +#ifndef SEGV_MTEAERR +# define SEGV_MTEAERR 8 +# define SEGV_MTESERR 9 +#endif + /* Return the number of tag granules in the memory range [ADDR, ADDR + LEN) given GRANULE_SIZE. */ extern size_t get_tag_granules (CORE_ADDR addr, size_t len, -- 2.17.1