From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OA+yH88Ijl+ERwAAWB0awg (envelope-from ) for ; Mon, 19 Oct 2020 17:44:47 -0400 Received: by simark.ca (Postfix, from userid 112) id 7EAC31EFBD; Mon, 19 Oct 2020 17:44:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DDD271EFBD for ; Mon, 19 Oct 2020 17:44:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A81623894C0C; Mon, 19 Oct 2020 21:44:39 +0000 (GMT) Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.197.25]) by sourceware.org (Postfix) with ESMTPS id 3BF5F3842435 for ; Mon, 19 Oct 2020 21:44:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BF5F3842435 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway30.websitewelcome.com (Postfix) with ESMTP id B608A8D2B for ; Mon, 19 Oct 2020 16:44:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id UcxFkILKTCjCVUcxFkazlL; Mon, 19 Oct 2020 16:44:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7HucfR6nPPKFwGhjeME+SiGd08xYcgkc3Pm4LZhHXJI=; b=X3yGjoDCvR0uVJcZ2NneRrR5Tx MvsG+emgDIUrgEbPUlWuhzP3ejo7LYFbgirPfA9s4By3F8NyD+NnNeGykRi5A/+ob9U5V/LrdhBt5 AD225xOvbeaDcQuyjs0xiNSAL; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:45712 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kUcxF-004Oci-7H; Mon, 19 Oct 2020 15:44:33 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH v2 04/16] Remove commented-out code from gcore.c Date: Mon, 19 Oct 2020 15:44:17 -0600 Message-Id: <20201019214429.13815-5-tom@tromey.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20201019214429.13815-1-tom@tromey.com> References: <20201019214429.13815-1-tom@tromey.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kUcxF-004Oci-7H X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (bapiya.Home) [75.166.102.113]:45712 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" I found some code in gcore.c that has been commented out since d3420b2fce5e (Mark Kettenis 2003-09-04 166) #if 1 /* See if this even matters... */ This patch deletes this code. gdb/ChangeLog 2020-10-19 Tom Tromey * gcore.c (default_gcore_mach): Remove commented-out code. --- gdb/ChangeLog | 4 ++++ gdb/gcore.c | 12 ------------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/gdb/gcore.c b/gdb/gcore.c index db82eaac3dd..c1ea7a6c481 100644 --- a/gdb/gcore.c +++ b/gdb/gcore.c @@ -168,19 +168,7 @@ gcore_command (const char *args, int from_tty) static unsigned long default_gcore_mach (void) { -#if 1 /* See if this even matters... */ return 0; -#else - - const struct bfd_arch_info *bfdarch = gdbarch_bfd_arch_info (target_gdbarch ()); - - if (bfdarch != NULL) - return bfdarch->mach; - if (exec_bfd == NULL) - error (_("Can't find default bfd machine type (need execfile).")); - - return bfd_get_mach (exec_bfd); -#endif /* 1 */ } static enum bfd_architecture -- 2.17.2