From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8sWOLJ9ohF8ragAAWB0awg (envelope-from ) for ; Mon, 12 Oct 2020 10:30:55 -0400 Received: by simark.ca (Postfix, from userid 112) id A9B461EF6F; Mon, 12 Oct 2020 10:30:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D9B4C1E58D for ; Mon, 12 Oct 2020 10:30:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A883388EC1F; Mon, 12 Oct 2020 14:30:54 +0000 (GMT) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 8A86B3861841 for ; Mon, 12 Oct 2020 14:30:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8A86B3861841 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x341.google.com with SMTP id q5so17741604wmq.0 for ; Mon, 12 Oct 2020 07:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3TDu1Js5z5mRhdUfNqL32jS8ijTL06LSYXQ/EUeuv54=; b=RrB8hyvyEQl7m/ZmBrQGhKtSDgjA15z7pfn/6LznOkNprP90Y8owZ8KOd6UO+TckEh 0nOdzbQOzOCG1Hk+i4ok9f45z3bzYwJZyUbwufTL3vjLg0ofrlrV5eE9kzLOJ7nun0RV /wxOFEyjQXRC32X4mEmDy6XPYxSMs99dw8lZ4i6zl2W2dprt0xpuYFxZZRYl6J8rQFH4 ez/YtwFZBTowUknI4zdR3xbjBV00om6bZzGxiOzyLBoUq2uDSI3aEXbaNnNnzG2Ixzkc Ut/roeApHl34m/gi+Bwe4OOdg8tEDaR9A6++eFInAaRMTuyl/ERELpmSDxeg4HvDsGq3 793A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3TDu1Js5z5mRhdUfNqL32jS8ijTL06LSYXQ/EUeuv54=; b=KgZcK3QkuoSeZsGqEk/ceQnkllCpVvCzOT03jwJegRvcbqpFgwFEapqjLJ2mPWBh3u EOYQ9sAilGDltmdkR9vjtJSDDtvLevXKHRPZ700ZhM6u9dzdM3dKAKilXa6yJzouBmXD qIUIpNZCTnvt2E2M1WcTo3NEkHdTaNZpa9YgJIzythzikk2XwrEADxRI7JKNvWijzOSm qDkaiBEmP8lg8kRKIUjJVczqCPdnpWepbTpLRgeDyY8FPUF4l46u7qgh9o/HUKRkAEcx 3cCVyp9MC00rYwtMdHCSdRhl02Y7RDhOysBU1NNTutJ5NAC7OyRmSGfxreYGpVl1PTPO 4kWA== X-Gm-Message-State: AOAM530wAxrYzpe4HZMOS38mjSSgS0TrCto/RW5kULWijyZpRRGqsuss KtKwEFmp97hK0R0jaxTmnhpYBQ== X-Google-Smtp-Source: ABdhPJyMDYB5tlaj63zKYZZZQ1IJ+DTrx5FaIEBVSBbIlElzbn2t3FdhQ8Ioc1E4DvC1oNQjcDoOBw== X-Received: by 2002:a1c:f70b:: with SMTP id v11mr11084657wmh.21.1602513050584; Mon, 12 Oct 2020 07:30:50 -0700 (PDT) Received: from localhost (host86-130-161-39.range86-130.btcentralplus.com. [86.130.161.39]) by smtp.gmail.com with ESMTPSA id v17sm13726858wru.44.2020.10.12.07.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 07:30:49 -0700 (PDT) Date: Mon, 12 Oct 2020 15:30:49 +0100 From: Andrew Burgess To: Alan Modra Subject: Re: gdb: Improve formatting of 'show architecture' messages Message-ID: <20201012143049.GT605036@embecosm.com> References: <20201012074604.GJ19404@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201012074604.GJ19404@bubble.grove.modra.org> X-Operating-System: Linux/5.8.12-100.fc31.x86_64 (x86_64) X-Uptime: 15:30:09 up 9 days, 6:42, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Alan Modra via Gdb-patches [2020-10-12 18:16:05 +1030]: > Commit ccb9eba6a25 updated the testsuite for some targets without > running the testsuite on those targets. This patch corrects the > update, in most cases just adding the expected full-stop. > > On powerpc64le-linux, fixes these: > FAIL: gdb.arch/powerpc-d128-regs.exp: checking for PPC arch > FAIL: gdb.arch/powerpc-disassembler-options.exp: set architecture powerpc:common64 > FAIL: gdb.arch/powerpc-disassembler-options.exp: set architecture rs6000:6000 > FAIL: gdb.arch/ppc64-symtab-cordic.exp: show architecture > > I also verified that arm-linuxeabi and s390x-linux cross-builds now > pass their disassembler-options.exp tests. > > OK to apply? > > * testsuite/gdb.arch/arm-disassembler-options.exp: Adjust expected > "target architecture" output. > * testsuite/gdb.arch/powerpc-d128-regs.exp: Likewise. > * testsuite/gdb.arch/powerpc-disassembler-options.exp: Likewise. > * testsuite/gdb.arch/ppc64-symtab-cordic.exp: Likewise. > * testsuite/gdb.arch/s390-disassembler-options.exp: Likewise. Remember these entries should be in gdb/testsuite/ChangeLog, and should not have 'testsuite/' at the start. Thanks, Andrew > > diff --git a/gdb/testsuite/gdb.arch/arm-disassembler-options.exp b/gdb/testsuite/gdb.arch/arm-disassembler-options.exp > index ac1d8a8bda..a3c0c0e5f8 100644 > --- a/gdb/testsuite/gdb.arch/arm-disassembler-options.exp > +++ b/gdb/testsuite/gdb.arch/arm-disassembler-options.exp > @@ -31,7 +31,7 @@ set arch1 "armv2" > set arch2 "armv5" > > gdb_test "set architecture $arch1" \ > - "The target architecture is set to \"$arch1\"" \ > + "The target architecture is set to \"$arch1\"\." \ > "set architecture $arch1" > > gdb_test_no_output "set disassembler-options" > @@ -47,7 +47,7 @@ gdb_test "show disassembler-options" \ > # Change architectures and verify the disassembler options have been preserved. > > gdb_test "set architecture $arch2" \ > - "The target architecture is set to \"$arch2\"" \ > + "The target architecture is set to \"$arch2\"\." \ > "set architecture $arch2" > > gdb_test "show disassembler-options" \ > diff --git a/gdb/testsuite/gdb.arch/powerpc-d128-regs.exp b/gdb/testsuite/gdb.arch/powerpc-d128-regs.exp > index e7bbccb271..cd96029fe8 100644 > --- a/gdb/testsuite/gdb.arch/powerpc-d128-regs.exp > +++ b/gdb/testsuite/gdb.arch/powerpc-d128-regs.exp > @@ -44,7 +44,7 @@ if { ![runto main] } then { > return > } > > -if [gdb_test "show arch" ".*currently powerpc:common.*" "checking for PPC arch"] { > +if [gdb_test "show arch" ".*powerpc:common.*" "checking for PPC arch"] { > return -1 > } > > diff --git a/gdb/testsuite/gdb.arch/powerpc-disassembler-options.exp b/gdb/testsuite/gdb.arch/powerpc-disassembler-options.exp > index 68d9bf61e1..9b3f8309fe 100644 > --- a/gdb/testsuite/gdb.arch/powerpc-disassembler-options.exp > +++ b/gdb/testsuite/gdb.arch/powerpc-disassembler-options.exp > @@ -31,7 +31,7 @@ set arch1 "rs6000:6000" > set arch2 "powerpc:common64" > > gdb_test "set architecture $arch1" \ > - "The target architecture is set to \"$arch1\"" \ > + "The target architecture is set to \"$arch1\"\." \ > "set architecture $arch1" > > gdb_test_no_output "set disassembler-options" > @@ -47,7 +47,7 @@ gdb_test "show disassembler-options" \ > # Change architectures and verify the disassembler options have been preserved. > > gdb_test "set architecture $arch2" \ > - "The target architecture is set to \"$arch2\"" \ > + "The target architecture is set to \"$arch2\"\." \ > "set architecture $arch2" > > gdb_test "show disassembler-options" \ > diff --git a/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp b/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp > index fa5bff9ceb..a1fa5ffabe 100644 > --- a/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp > +++ b/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp > @@ -47,10 +47,10 @@ gdb_load ${kofile} > > set test "show architecture" > gdb_test_multiple $test $test { > - -re "\r\nThe target architecture is set to \"auto\" \\(currently \"powerpc:common64\"\\)\r\n$gdb_prompt $" { > + -re "\r\nThe target architecture is set to \"auto\" \\(currently \"powerpc:common64\"\\)\.\r\n$gdb_prompt $" { > pass $test > } > - -re "\r\nThe target architecture is set to \"auto\" \\(currently \".*\"\\)\r\n$gdb_prompt $" { > + -re "\r\nThe target architecture is set to \"auto\" \\(currently \".*\"\\)\.\r\n$gdb_prompt $" { > untested "powerpc:common64 is not supported" > } > } > diff --git a/gdb/testsuite/gdb.arch/s390-disassembler-options.exp b/gdb/testsuite/gdb.arch/s390-disassembler-options.exp > index a9ae230aa0..16e7cd18d7 100644 > --- a/gdb/testsuite/gdb.arch/s390-disassembler-options.exp > +++ b/gdb/testsuite/gdb.arch/s390-disassembler-options.exp > @@ -31,7 +31,7 @@ set arch1 "s390:64-bit" > set arch2 "s390:31-bit" > > gdb_test "set architecture $arch1" \ > - "The target architecture is set to \"$arch1\"" \ > + "The target architecture is set to \"$arch1\"\." \ > "set architecture $arch1" > > gdb_test_no_output "set disassembler-options" > @@ -47,7 +47,7 @@ gdb_test "show disassembler-options" \ > # Change architectures and verify the disassembler options have been preserved. > > gdb_test "set architecture $arch2" \ > - "The target architecture is set to \"$arch2\"" \ > + "The target architecture is set to \"$arch2\"\." \ > "set architecture $arch2" > > gdb_test "show disassembler-options" \ > > -- > Alan Modra > Australia Development Lab, IBM