From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IMFyEPBAhF+XZgAAWB0awg (envelope-from ) for ; Mon, 12 Oct 2020 07:41:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 3FE091EF6F; Mon, 12 Oct 2020 07:41:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CACB21E58C for ; Mon, 12 Oct 2020 07:41:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC48C38708E5; Mon, 12 Oct 2020 11:41:34 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 34F87386EC23 for ; Mon, 12 Oct 2020 11:41:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 34F87386EC23 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0B63E117BBC; Mon, 12 Oct 2020 07:41:32 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zOLT2fimM70c; Mon, 12 Oct 2020 07:41:31 -0400 (EDT) Received: from takamaka.brobecker.org (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C93F9117BA4; Mon, 12 Oct 2020 07:41:31 -0400 (EDT) Received: by takamaka.brobecker.org (Postfix, from userid 1000) id 4CB02865E3; Mon, 12 Oct 2020 04:41:30 -0700 (PDT) Date: Mon, 12 Oct 2020 04:41:30 -0700 From: Joel Brobecker To: Andrew Burgess Subject: Re: [PATCH] gnulib: Ensure all libraries are used when building gdb/gdbserver Message-ID: <20201012114130.GA28251@adacore.com> References: <20201005165134.1620549-1-andrew.burgess@embecosm.com> <2feb66c2-8f65-7cbf-d1be-ae3d04b45d9a@simark.ca> <20201006121751.GK605036@embecosm.com> <95d52add-47c2-9621-7e60-1ff9a4331324@simark.ca> <20201007153319.GL605036@embecosm.com> <20201009083436.GP605036@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009083436.GP605036@embecosm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Andrew, On Fri, Oct 09, 2020 at 09:34:36AM +0100, Andrew Burgess wrote: > * Andrew Burgess [2020-10-07 16:33:19 +0100]: > > > * Simon Marchi [2020-10-06 10:10:25 -0400]: > > > > > On 2020-10-06 8:17 a.m., Andrew Burgess wrote: > > > > The problem here was me unconditionally trying to include > > > > Makefile.gnulib.inc from the gdb and gdbserver Makefile. The very > > > > first time you run 'make clean' after applying the patch > > > > Makefile.gnulib.inc doesn't exist, but the gdb/gdbserver makefiles > > > > still try to pull the file in unconditionally. > > > > > > If the file is generated at configure-time, I think it would be ok for > > > Makefile.gnulib.inc to be included unconditionally. As when you run > > > "make clean" after pulling some changes, you're supposed to do to it > > > from the top level, so Makefile.gnulib.inc will be created before "make > > > clean" runs in GDB. > > > > OK, I made the include compulsory. > > > > > > > > > > > > Finally, I don't know if the change was intentional, but the file was > > > previously named Makefile.gnulib.inc and is now named Makefile.gnulib. > > > I liked Makefile.gnulib.inc, as it shows it's not a "top-level" > > > Makefile, it's meant to be included. > > > > I just thought 'Makefile.gnulib.inc.in' was a bit much (in the source > > tree), but I don't really mind. I changed back to use this filename. > > > > The patch below has these two fixes. I'll apply in a couple of days > > unless anyone objects. > > I've now pushed this patch. I got reports of the nightly source packaging failing soon after you pushed this patch, and I was able to reproduce it by configuring (out of tree), followed by a "make distclean". I did a "make -C gdb install" as well, but I don't think it should have any influence on the outcome. The error I get is the following: | Makefile:246: ../gnulib/Makefile.gnulib.inc: No such file or directory | make[2]: *** No rule to make target '../gnulib/Makefile.gnulib.inc'. Stop. | make[2]: Leaving directory '/[...]/gdb' Do you think you could look into it? Thank you! -- Joel