From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uPSgDB+XbV/pFQAAWB0awg (envelope-from ) for ; Fri, 25 Sep 2020 03:07:11 -0400 Received: by simark.ca (Postfix, from userid 112) id 256981EF4B; Fri, 25 Sep 2020 03:07:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D17C1E599 for ; Fri, 25 Sep 2020 03:07:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0378F3857015; Fri, 25 Sep 2020 07:07:08 +0000 (GMT) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by sourceware.org (Postfix) with ESMTPS id 0F9703857C7B for ; Fri, 25 Sep 2020 07:07:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0F9703857C7B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=saagarjha.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=saagarjha28@gmail.com Received: by mail-pg1-f193.google.com with SMTP id t14so1739782pgl.10 for ; Fri, 25 Sep 2020 00:07:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cgMSoEMUhFPaHWuMS5A7bHRPL5Yd8cQRm/hb4pxn9Ws=; b=XB0pVxphj+mELvpYX+pEbnTESKcUzIXMoQiO3TRqgYQwlfv7Ef7P7Q72pL3nmSD8si AclMrLARqgmV4JxSg5f20JTaERlLRe/ekfrY55FMcMwzgMK0uKxbkcL6bMjOTmUKl6wf pzDB33OQTTGw+C7TM4IPDZoQPDo/G8sSsxr2kTrmAoZHhldDe0PkEkcXhU5wT6LsMEvq crBZ69Pu1qAk290Po04tNSGiK1ET/ohGTimxj1teaZi7gkIndNX4ZfCmYQxy+l2ERH3A R/vCjDa65wkUlHzegmQ3IPv9MhaJoo3kP05+q2F3/CzZH+osiv72R8UpBdMe+JJPgca9 RjYg== X-Gm-Message-State: AOAM533DE/X11TKLDgaEho6BZKfi9gPf/uXOlxKdSLyVTjubqQSWntvb CcBJD92cCiGk3l5QR8RuFgXIM8yVZBU= X-Google-Smtp-Source: ABdhPJwhDSqEJGamyaHf4xk9Nkt26P93T2egXFm4TpQkxzQQqFK0zrc/4uLV3bZH/BPH4LBddK9Mug== X-Received: by 2002:a62:301:0:b029:13c:1611:6528 with SMTP id 1-20020a6203010000b029013c16116528mr2727766pfd.8.1601017624902; Fri, 25 Sep 2020 00:07:04 -0700 (PDT) Received: from localhost.localdomain ([73.92.124.25]) by smtp.gmail.com with ESMTPSA id c1sm1545196pfj.219.2020.09.25.00.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 00:07:04 -0700 (PDT) From: Saagar Jha To: gdb-patches@sourceware.org Subject: [PATCH] Add a missing munmap_list move constructor Date: Fri, 25 Sep 2020 00:05:25 -0700 Message-Id: <20200925070525.47993-2-saagar@saagarjha.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200925070525.47993-1-saagar@saagarjha.com> References: <883A80DB-0918-4BA6-B387-A54581BFEA42@saagarjha.com> <20200925070525.47993-1-saagar@saagarjha.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Saagar Jha Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" compile_module attempts to request a move constructor, but because munmap_list doesn't have one it gets implicitly deleted. This is an warning on clang under -Wdefaulted-function-deleted (which is enabled by default): In file included from compile/compile-object-load.c:21: compile/compile-object-load.h:56:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] compile_module (compile_module &&other) = default; ^ compile/compile-object-load.h:86:22: note: move constructor of 'compile_module' is implicitly deleted because field 'munmap_list' has a deleted move constructor struct munmap_list munmap_list; ^ compile/compile-object-load.h:30:28: note: 'munmap_list' has been explicitly marked deleted here DISABLE_COPY_AND_ASSIGN (munmap_list); ^ gdb/ChangeLog: * compile/compile-object-load.h: Give munmap_list a move constructor. --- gdb/ChangeLog | 5 +++++ gdb/compile/compile-object-load.h | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3872a8d9cb..043c6a4c72 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-09-25 Saagar Jha + + * compile/compile-object-load.h: Give munmap_list a move + constructor. + 2020-09-24 Tom Tromey PR tui/26638: diff --git a/gdb/compile/compile-object-load.h b/gdb/compile/compile-object-load.h index 0254390109..166d442ad0 100644 --- a/gdb/compile/compile-object-load.h +++ b/gdb/compile/compile-object-load.h @@ -30,6 +30,7 @@ struct munmap_list DISABLE_COPY_AND_ASSIGN (munmap_list); munmap_list &operator= (munmap_list &&) = default; + munmap_list (munmap_list &&) = default; /* Add a region to the list. */ void add (CORE_ADDR addr, CORE_ADDR size); -- 2.28.0