From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1dKiDq+dbF+ZfAAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 09:22:55 -0400 Received: by simark.ca (Postfix, from userid 112) id 2ECD11EE05; Thu, 24 Sep 2020 09:22:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D24D11E599 for ; Thu, 24 Sep 2020 09:22:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6702C3857C52; Thu, 24 Sep 2020 13:22:53 +0000 (GMT) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id 07C3B3857C52 for ; Thu, 24 Sep 2020 13:22:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 07C3B3857C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x441.google.com with SMTP id w5so3790612wrp.8 for ; Thu, 24 Sep 2020 06:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e57E9l5UOXt0Rq0brgmfJnFiHpWf18Ytu5DXbukl+1w=; b=cr7Ve8QYP5I3IurYgEx1t8/YpBn86TmIZ0tXNP5OEYyZAKrLOOTwsPx65vi1hlBSgA iPiJn0s3WLcHd2TXddypNfWosWYu2Yf4tgjq12z7fy5ETmV7EPnaW6UpZVulU5xdRrju FoMmPoWJdhWIwb8ZLccW2xxjbTlwirBPidSi7MdmPHcZ0Us0ZQFn5gOz4NzJrYg4iOPM jNrHr08j69LimBYlDwwniySX+0lL9YY5Lk919NtOlDhoTSEGlboaNBt493V4RSrIPAgq 5Rkrnq+YXv7XIixs8HJVKJfa2FuLXVJeYLFeAva5y45rXqLb0Bpt8pb64V1Wp/takms+ JvlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e57E9l5UOXt0Rq0brgmfJnFiHpWf18Ytu5DXbukl+1w=; b=PSDkVwUn1i8nzoiBTF86he/TRt/C5w1vleHJzMIXgDNg4ywLXHjr3FfTxTwyjqZZt7 bQd5P6/n38kXmZSmojnhoL8BF9zcbNj326z0DFNPdjwdEew97hlmz/JaFBOMhfKXDemI EZiJUlQvetrTZoYxtW34RAr48ll+pN/OWX0uzCdv/X156trSpjuDQqQx13Ca39Gr+Qmf LB37oj3/e+mK2e4z5RSvGECj7J36OSqs8KGBGTSHkFOfFEMyv1CSviTSoZAzfqaFjMBg GvGrskDCeuIClyANzH++umYl9jtEbg0uhAGeuEBefTg9nR4JE8XtaTZTYDFq4qhpLv83 Qx3A== X-Gm-Message-State: AOAM532tupMBg7Yz0qX2INaNRfwvEvfPsU0jFyIaal7r+0beBBoSNfJK 2slglPj/wbN7Nky+q8DBhcIcig== X-Google-Smtp-Source: ABdhPJxVOddAQ3rBe0QPKaG3ZZMN1k4xAgzST7G/in4az3vs5wKoPTi81jvIZ3y2WoNjoSwWyTQBHA== X-Received: by 2002:a5d:4842:: with SMTP id n2mr5200172wrs.260.1600953768933; Thu, 24 Sep 2020 06:22:48 -0700 (PDT) Received: from localhost (host31-53-80-104.range31-53.btcentralplus.com. [31.53.80.104]) by smtp.gmail.com with ESMTPSA id a5sm3690106wrp.37.2020.09.24.06.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 06:22:48 -0700 (PDT) Date: Thu, 24 Sep 2020 14:22:47 +0100 From: Andrew Burgess To: Pedro Alves Subject: Re: [PATCH v2] disass: Add /x modifier to print offsets in hex Message-ID: <20200924132247.GL1540618@embecosm.com> References: <20200923101906.2897399-1-fam@euphon.net> <20200924110514.GJ1540618@embecosm.com> <22205c9c-aab7-c160-661a-e1a500d28f7d@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22205c9c-aab7-c160-661a-e1a500d28f7d@palves.net> X-Operating-System: Linux/5.8.9-101.fc31.x86_64 (x86_64) X-Uptime: 14:20:52 up 5 days, 21:28, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Pedro Alves [2020-09-24 13:20:56 +0100]: > On 9/24/20 12:05 PM, Andrew Burgess wrote: > > * fam@euphon.net [2020-09-23 10:19:06 +0000]: > > > >> From: Fam Zheng > >> > >> Backtrace messages printed by Linux kernel and Xen have hex offsets, > >> e.g.: > >> > >> (XEN) Xen call trace: > >> (XEN) [] R guest_walk_tables_2_levels+0x189/0x66d > >> (XEN) [] F hap_p2m_ga_to_gfn_2_levels+0x112/0x25b > >> (XEN) [] F hap_gva_to_gfn_2_levels+0x1c/0x1e > >> (XEN) [] F paging_gva_to_gfn+0x14a/0x167 > >> > >> Having this modifier saves converting between hex values from the > >> backtrace log and offsets in gdb disass output. > >> > >> --- > >> > >> v2: Drop a overlooked change on file header. > >> --- > >> gdb/cli/cli-cmds.c | 17 ++++++++++++----- > >> gdb/disasm.c | 6 +++++- > >> gdb/disasm.h | 1 + > >> gdb/record.c | 3 +++ > >> 4 files changed, 21 insertions(+), 6 deletions(-) > >> > >> diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c > >> index e3965fea07..2266f67695 100644 > >> --- a/gdb/cli/cli-cmds.c > >> +++ b/gdb/cli/cli-cmds.c > >> @@ -1456,12 +1456,12 @@ disassemble_current_function (gdb_disassembly_flags flags) > >> /* Dump a specified section of assembly code. > >> > >> Usage: > >> - disassemble [/mrs] > >> + disassemble [/mrsx] > >> - dump the assembly code for the function of the current pc > >> - disassemble [/mrs] addr > >> + disassemble [/mrsx] addr > >> - dump the assembly code for the function at ADDR > >> - disassemble [/mrs] low,high > >> - disassemble [/mrs] low,+length > >> + disassemble [/mrsx] low,high > >> + disassemble [/mrsx] low,+length > >> - dump the assembly code in the range [LOW,HIGH), or [LOW,LOW+length) > >> > >> A /m modifier will include source code with the assembly in a > >> @@ -1472,6 +1472,8 @@ disassemble_current_function (gdb_disassembly_flags flags) > >> > >> A /r modifier will include raw instructions in hex with the assembly. > >> > >> + A /x modifier will print offsets in hex. > > > > Shouldn't this be 'An /x modified ...' ? Saying it out loud it > > certainly seems that way. > > Not if you read it as "a slash x modifier". > > I would guess that that's why it's also written "A /r" and "A /m modifier"? I withdraw my suggestion then. Sorry for the noise. Andrew