From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mK4VMi6Ea19WYQAAWB0awg (envelope-from ) for ; Wed, 23 Sep 2020 13:21:50 -0400 Received: by simark.ca (Postfix, from userid 112) id BF1661EF4B; Wed, 23 Sep 2020 13:21:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B069A1E509 for ; Wed, 23 Sep 2020 13:21:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE337394D82B; Wed, 23 Sep 2020 17:21:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE337394D82B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1600881709; bh=HTkCCew2zYmcofetd6ZPk7G+AWXAYOBkwiuXeVRxAqc=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=g93jLpo1LnpohcxJWhX+wHJbTh+n3Iu4Ue6jrWAwShgzkwT8FTnnMt+vMMDy/yAM/ axZxXQi35GFtU/OT+7GHWRPRd56HMsvjd65J0jdY+URCeu0Rrraqr09lyujUNeXcmz 3IUp6NO7F1ig9GuhYOAjnjslj16jfSHm4yyyHtVc= Received: from sonic305-20.consmr.mail.ir2.yahoo.com (sonic305-20.consmr.mail.ir2.yahoo.com [77.238.177.82]) by sourceware.org (Postfix) with ESMTPS id F2B84386101B for ; Wed, 23 Sep 2020 17:21:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F2B84386101B X-YMail-OSG: IC7puBkVM1nCwI68l2tnRQWenQiHXim0kvjNbiIZDStIY7P2VqYZ0UyLXo7cBk9 EYPDTUdBIOz_6W8F1iWbpubY1Qep1P6Tt_JH4URo0Sd6WzRxucKVbdrJ0kWS03IEfGFZ0FjHI_3k QZBfWO6.ioDTHDg_LRMPTr0PwwxtulfEyMI..O4IukToZSU9oVQ0cccp5wmeULFZuOr.uGXRPiTD Pg2.SXeSpZ6LRtNocB9Og.nt5R6_HOTm4GJghZ0JkeOCbCCUrkPOzVF6rVroJbYRvqzdkLQ6AC6B __tfDNb9QTBs_x0ObJP9.tchuAnb.kGPO1Ij417ZlGEq4zqJuAuqh9UhTEXpwkqOthw22XR7J44y wHDGqFT8eGQ5ZUEIVZ0yB3rFPlQ3tFmf3lpCZJT2ZWjn9rCd1Y.I_Ur3vls5h8j4rnKnbGCbT7Mp TfMIy3kkqCZ3JWFLaqp1PVdw1Y8NaWCIAbqcjJTRLfhw76X8nMpgOjcX_e65hb2wQSDjaehhvQCW V1vACQWkopOUE2ByFn4UW5clIlqaFBQjLExLC4y585N1KsX3O8PTswZjRD.tnhMkHxBn.iDOglg_ KD09eqXKjV0PDMNUyf_a1_wYZzlndpJgzM9Bqt9Rbs7FNbkmwJfWhW4Zh6A4bSKLX7Svc48Go_95 tY50LBvWX7QgnDsKY9aazjsoQzFiAiyThJbJxCTo.wFPqXmH5MePzxIjO0UnEITQU3B3J4juQd9Z HYSZ1CHXlw3grd39kHyvVzABZCBP7vT._4Vy55q1UkjPbzBu_7ciijbBOzd_vmfzz6XIFLW.malo 7i01b0eP9oXZLucTAK4U_QHLvYKF7Mayjf4RvbCBmd7P.u9_BopHZtf4mYH.ftx3KWOBEhS90lMZ oDEJVRqh7ST5aM6ekMX983Xz24_GUa4TVEfRBHZqiFsXE23NmseDsO_F8hcUWNa2Zl2I78_4cNLt 6o.2Ax1LKAj7zMfpxuD0AHXTA1XoPMkZReFKA5v7E_fuQwlcENgFs5aSTQyI3YyqEIKw7pJUC.UG O8QRrowRcMFsElpURGmBkNmminDsCTXAWi1buMtcDh27FIkcA1.Jv0egHwxXPNqd64HoYseY_Xpw LLBYaP5NS3YtxnhFEAneKJv.DuS7WNW7.3oDpbe6SnEtwhGySzx3t3hBH1z8lL6WV0VJAdhEHC4G fvLrbCJcJfYJujAigxX2Et4Vh3UfhIY_MkRK4wenj9MSvaz_Tf_vgavEjkgQZhpkydew_c2JENS7 W6T7J9JDFiPkjN5ab2dsBj_9VdDVjvZGeEZRhugdZfdBVRBhS_x3xCF9QcG479Qkp4slC44Wgo8p wB8oSpmIeHYaReIFfD9vXc6gOiiAyiebWPFKlZff3hYAD6Rh3YCOzvKAiygItGR0E.CSOCtck2tL I.om3zt98l9dvyAyEWms3sg0WuxZBAtr1WS8e0HG92XeQ1.mvhma4Bw5atBBXtZg90iJF60m7EtK xtSss0_nRX2YS5w5COjb4kVgOV9oFxiy.XqxBbE3E2RhpDehSdU98IVWhf5AZEA6WsNilsPubMs6 iWtc5PA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Wed, 23 Sep 2020 17:21:45 +0000 Received: by smtp405.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 09a9a830d4366d0a19bd006c6c28dbf6; Wed, 23 Sep 2020 17:21:43 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 3/3] Remove call of GenerateConsoleCtrlEvent Date: Wed, 23 Sep 2020 19:21:22 +0200 Message-Id: <20200923172122.2089-3-ssbssa@yahoo.de> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200923172122.2089-1-ssbssa@yahoo.de> References: <20200923172122.2089-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Antivirus: Avast (VPS 200923-0, 09/23/2020), Outbound message X-Antivirus-Status: Clean X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c event was created in the target process (like if the target doesn't have a console). Since this prevents DebugBreakProcess from being called (which should always work), this removes it. gdbserver/ChangeLog: 2020-09-23 Hannes Domani * win32-low.cc (win32_process_target::request_interrupt): Remove call of GenerateConsoleCtrlEvent. --- gdbserver/win32-low.cc | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 588a23a643..d50fc4c98e 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -101,7 +101,6 @@ const struct target_desc *wow64_win32_tdesc; typedef BOOL (WINAPI *winapi_DebugActiveProcessStop) (DWORD dwProcessId); typedef BOOL (WINAPI *winapi_DebugSetProcessKillOnExit) (BOOL KillOnExit); typedef BOOL (WINAPI *winapi_DebugBreakProcess) (HANDLE); -typedef BOOL (WINAPI *winapi_GenerateConsoleCtrlEvent) (DWORD, DWORD); #ifdef __x86_64__ typedef BOOL (WINAPI *winapi_Wow64SetThreadContext) (HANDLE, @@ -1694,7 +1693,6 @@ void win32_process_target::request_interrupt () { winapi_DebugBreakProcess DebugBreakProcess; - winapi_GenerateConsoleCtrlEvent GenerateConsoleCtrlEvent; #ifdef _WIN32_WCE HMODULE dll = GetModuleHandle (_T("COREDLL.DLL")); @@ -1702,17 +1700,6 @@ win32_process_target::request_interrupt () HMODULE dll = GetModuleHandle (_T("KERNEL32.DLL")); #endif - GenerateConsoleCtrlEvent = GETPROCADDRESS (dll, GenerateConsoleCtrlEvent); - - if (GenerateConsoleCtrlEvent != NULL - && GenerateConsoleCtrlEvent (CTRL_BREAK_EVENT, current_process_id)) - return; - - /* GenerateConsoleCtrlEvent can fail if process id being debugged is - not a process group id. - Fallback to XP/Vista 'DebugBreakProcess', which generates a - breakpoint exception in the interior process. */ - DebugBreakProcess = GETPROCADDRESS (dll, DebugBreakProcess); if (DebugBreakProcess != NULL -- 2.27.0