Re: [PATCH] Import mklog.py from gcc repo

Martin Liška
2020-09-21T12:45:13Z

On 9/18/20 4:50 PM, Simon Marchi via Binutils wrote:
> On 2020-09-18 10:27 a.m., Christian Biesinger wrote:
>> I like this in principle, but the one annoying part is that no longer
>> prints the patch author/date line, so you have to manually create it.
>> I suppose one could make their own script for that (or maybe emacs
>> users have a macro for that or something)...
>
> I think you could add an option to the script to do this, I don't see
> why they would reject that. I don't know what the workflow of the gcc
> devs is regarding this.

I removed it as author and timestamp lines are automatically generated
based on git commit information.

>
> But it's not a problem from my point of view. I prefer to write my
> ChangeLog entries in the commit message without the header. I think
> it's pointless to put a date there, because the final date will be the
> date where I actually push the patch on the upstream master branch. And
> the name/email is redundant with the author name/email of the commit.
>
> I use a script [1] to insert the entries in the ChangeLog files and
> amend the commit when I'm about to push to upstream master. The script
> automatically generates the date/name/email line at that moment.

Note that some time ago I offered the gcc-changelog script to binutils community
and it was basically rejected. [1] is a motivation example as anybody has it's
own script to mechanically modify a timestamp and apply ChangeLog entries.
It's a legwork.

Martin

>
> Simon
>
> [1] https://github.com/simark/gnu-changelog-tools/blob/master/changelog-git-amend/changelog-git-amend.py
>