From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id B4FE33857C46 for ; Fri, 18 Sep 2020 09:53:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4FE33857C46 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42e.google.com with SMTP id z4so4971751wrr.4 for ; Fri, 18 Sep 2020 02:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5535RTixB2MzQZHrGNAWCFsmQ2bU0Z3GEVT9iQhGno8=; b=QPin3MZMYENDpsYMHxmGLtfcUsGVaDrRlrlI8+mKk7LA3hW39D+hi70Q/b8YGhRXEE hO7SizjYXFvys2NuP8AzCww9Z7pozuX69ogkFHFB1c07KOoXoHobnByGe5JduP6BxZ7v 92D7RD5wUTlOIXg5APg2Mxxt+CjriSLiaOlCTaQiemnQ7TK4ZiVpjh2utQgs2eXzKr98 iOBE37DopNL8KLTUMlYql3i/IL9nlpn6oqMI7N849l0+qwKa4EiCiO/GT+agOTQ/c+f2 4gTPCMOpGIku033UYmBjSydXcHuAtkg7e0lAeVXXRumOBCubqqvs/DhgRDHc6DEjBu8p EAUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5535RTixB2MzQZHrGNAWCFsmQ2bU0Z3GEVT9iQhGno8=; b=pzV0sDkrHrhYT4N8X9DfYwQ9dCUtmOA5tHaaZE/DTfBjbPUo2qYGXosflbKrlFfuAp U7MV8hSJh4raXfFdrdj3qOg6TDZsiIeF23v0GLf2dZLovdZ/kfeqriMOB+6gFjcihDHQ S40jSWzyL/86m1uze4vIpqBQCql7aOyvult52//2ZlwpEFh5VeyrpmG0o0JyrR7/J6vu PJQQPjfvYd0qg5rx4yI9lUXzHnhmHO9Vpbi7lp2zYtYdmx982ievUq5IKGyE6jfOLGXr hHN7Gc0KeQ9UjhFFhecVCqZYTjBpKVQWq2tuLDgfqW8e2TrZbKgH9Ktd6QClUMe8e+Mm q6rQ== X-Gm-Message-State: AOAM533gS7s2+aAqL9g/V23AfsLlKnxP9QEBBfcZq0WDw/YupvPfm6x6 04eXX3KT1XvfYcHQLBb/U4cOaBj7NjcTCQ== X-Google-Smtp-Source: ABdhPJxWGQk1bImsHMKq22HVsOcz3y7G/wGUativdDtN/0d7QA4/gs+R5DLIi1ErZJoiPDtURM23dQ== X-Received: by 2002:adf:a18c:: with SMTP id u12mr38504468wru.90.1600422834458; Fri, 18 Sep 2020 02:53:54 -0700 (PDT) Received: from localhost (host31-53-80-104.range31-53.btcentralplus.com. [31.53.80.104]) by smtp.gmail.com with ESMTPSA id u66sm18911348wme.1.2020.09.18.02.53.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 02:53:53 -0700 (PDT) Date: Fri, 18 Sep 2020 10:53:52 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv2 09/10] gdb/testsuite: Add missing expected results Message-ID: <20200918095352.GC2697@embecosm.com> References: <74a1efdd3ea0cc469859ded4151a9c2479a05172.1598452395.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74a1efdd3ea0cc469859ded4151a9c2479a05172.1598452395.git.andrew.burgess@embecosm.com> X-Operating-System: Linux/5.8.6-101.fc31.x86_64 (x86_64) X-Uptime: 10:53:27 up 5 days, 18:17, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 09:53:57 -0000 I have pushed this patch with a slightly modified commit message. Thanks, Andrew * Andrew Burgess [2020-08-26 15:49:16 +0100]: > The tests in this script are driven from two lists of expected > results, one of the lists is missing some data so DejaGNU ends up > matching against the empty string (which passes). > > This commit adds the missing expected results into the script. > > I could rewrite this test to make things more robust, however, a later > commit is going to completely rewrite this test script, I'm simply > adding this here so that _before_ the rewrite the test is complete, > then if anyone ever digs into the history of this test script things > will make sense (I hope). > > gdb/testsuite/ChangeLog: > > * gdb.fortran/array-slices.exp: Add missing message data. > --- > gdb/testsuite/ChangeLog | 4 ++++ > gdb/testsuite/gdb.fortran/array-slices.exp | 5 ++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.fortran/array-slices.exp b/gdb/testsuite/gdb.fortran/array-slices.exp > index 8587c51e990..31f95a3668d 100644 > --- a/gdb/testsuite/gdb.fortran/array-slices.exp > +++ b/gdb/testsuite/gdb.fortran/array-slices.exp > @@ -53,7 +53,10 @@ set message_strings \ > " = 'array \\(1:5,1:5\\)'" \ > " = 'array \\(1:10:2,1:10:2\\)'" \ > " = 'array \\(1:10:3,1:10:2\\)'" \ > - " = 'array \\(1:10:5,1:10:3\\)'" ] > + " = 'array \\(1:10:5,1:10:3\\)'" \ > + " = 'other'" \ > + " = 'other \\(-5:0, -2:0\\)'" \ > + " = 'other \\(-5:4:2, -2:7:3\\)'" ] > > set i 0 > foreach result $array_contents msg $message_strings { > -- > 2.25.4 >