From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by sourceware.org (Postfix) with ESMTPS id C72783857C44 for ; Thu, 17 Sep 2020 08:49:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C72783857C44 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x442.google.com with SMTP id t10so1151043wrv.1 for ; Thu, 17 Sep 2020 01:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=f9eWcfUVCyDGRVvOXfpx+Z0A8k6KU2SDJjKTcFx0mLc=; b=WlKnx13JtuqBDe4dGbStXTNePaHBHiNjmx6qGcIUD+9h8cViMv2xpd/Bt0qsyxr0AY BUjH+83p4rI76SrW5nFO8kvRPkDpsIt6Eeabta+zM8gHEglaU+xiemEve7H2olu/PQLX DIU5OXejhO1kE/AZAY9CrY/Dw8ylPkYLLEhvixPIFRNveSFr7uqwbTpUYc52ajpRMuEo GqGgXrLDkCDttGPt6i2YzS1WN7C5L4gTihQo5JM+AWr4n6VMVwC1evaFJfKXWpi9d45T ZFr7w+CdBKsEHIc4xNkit+7zbu8ab6VZLKsK7RKGbRxhhtFPjTAeZVSYfxsN+b/WT/zB K+Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=f9eWcfUVCyDGRVvOXfpx+Z0A8k6KU2SDJjKTcFx0mLc=; b=OZCxcaciJvzLvBbX8M4wB8pRNipzYVFOYWNaccYcxar5r1JDy+n2vF2e9Ax7p5eDF1 ku5bdyLssyaEzdbFMmTb2v6cG4RVDBwt2upAPV6+o7e+5r0RlDPCbmtRBcldeId8ylfB sJAubxIkArU5571BtOK1/v/eDuWHXuOL8d9yA0Q6kc6dRmN2RIX63FvKkN8UYGHzrFDG LrGHTXPPdkfmB7+jqIWRoE1FsGtAPVxuWNLoS9F6rXnx8rTFOns5wxRfrayXfY2mjZ3A lZOVLSmX67upHiVSCnWDknGyKhsfQZsfZizm1lQiAPo74MI4iTOi8cp4umud/SSR4hOW 8+5g== X-Gm-Message-State: AOAM531DRxPxO327zLCjRHeg0WWeRTn/H67MGo/+uerVbZliJluKKARd FCYwUb/hVY45ELCTGeo2ORVVPtKwT82Iew== X-Google-Smtp-Source: ABdhPJzprVe5q2nYu+RL5eIQgOZTqEnLj/SwqHq1T5vbs+xINxQH+K1+JpOBMAS+x5W4cu8rLNULZw== X-Received: by 2002:adf:ed09:: with SMTP id a9mr30346944wro.407.1600332570918; Thu, 17 Sep 2020 01:49:30 -0700 (PDT) Received: from localhost (host31-53-80-104.range31-53.btcentralplus.com. [31.53.80.104]) by smtp.gmail.com with ESMTPSA id u126sm12465790wmu.9.2020.09.17.01.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 01:49:30 -0700 (PDT) Date: Thu, 17 Sep 2020 09:49:28 +0100 From: Andrew Burgess To: =?utf-8?B?57SA6YeN56aV?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/riscv: fix recorded insn type Message-ID: <20200917084928.GB2697@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Operating-System: Linux/5.8.6-101.fc31.x86_64 (x86_64) X-Uptime: 09:49:01 up 4 days, 17:12, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 08:49:33 -0000 Thanks for catching this. I have pushed this fix. Thanks, Andrew * =E7=B4=80=E9=87=8D=E7=A6=95 [2020-09-17 10:14:05 +0800]: > Hi, I fixed the instruction type in the decoding method. > --- > gdb/ChangeLog | 3 +++ > gdb/riscv-tdep.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 84ee292750..5bf0c8ff14 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,6 @@ > +2020-09-17 Chungyi Chi > + * riscv-tdep.c (riscv-insn::decode): Fix recorded insn type. > + > 2020-09-16 Simon Marchi >=20 > * breakpoint.h (init_catchpoint): Change int parameter to bool. > diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c > index a7c25642d0..ac4ac1b6fd 100644 > --- a/gdb/riscv-tdep.c > +++ b/gdb/riscv-tdep.c > @@ -1472,7 +1472,7 @@ riscv_insn::decode (struct gdbarch *gdbarch, > CORE_ADDR pc) > else if (is_c_swsp_insn (ival)) > decode_css_type_insn (SW, ival, EXTRACT_RVC_SWSP_IMM (ival)); > else if (xlen !=3D 4 && is_c_sdsp_insn (ival)) > - decode_css_type_insn (SW, ival, EXTRACT_RVC_SDSP_IMM (ival)); > + decode_css_type_insn (SD, ival, EXTRACT_RVC_SDSP_IMM (ival)); > /* C_JR and C_MV have the same opcode. If RS2 is 0, then this is a > C_JR. > So must try to match C_JR first as it ahs more bits in mask. */ > else if (is_c_jr_insn (ival)) > --=20 > 2.25.0