From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 6C88E3857C72 for ; Wed, 16 Sep 2020 08:58:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C88E3857C72 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D7FE9AC8B; Wed, 16 Sep 2020 08:58:18 +0000 (UTC) Date: Wed, 16 Sep 2020 10:58:01 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [committed][gdb/testsuite] Fix unbalanced braces in gdb.tui/new-layout.exp Message-ID: <20200916085800.GA17089@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 08:58:05 -0000 Hi, On SLE-11 with tcl version 8.5, we run into: ... UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to \ invalid command name: } ERROR: Couldn't send tui new-layout example src 1} to GDB. ... Apparently tcl 8.6 is more forgiving about unbalanced braces. Expose the unbalanced braces on tcl 8.6 by temporarily wrapping the test-case in: ... proc do_this { args } { uplevel 1 {*}$args } do_this { ... } ... and escape them using a backslash. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix unbalanced braces in gdb.tui/new-layout.exp gdb/testsuite/ChangeLog: 2020-09-16 Tom de Vries PR testsuite/26618 * gdb.tui/new-layout.exp: Escape unbalanced braces. --- gdb/testsuite/gdb.tui/new-layout.exp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.tui/new-layout.exp b/gdb/testsuite/gdb.tui/new-layout.exp index b4fca674e8..57c3f75e3b 100644 --- a/gdb/testsuite/gdb.tui/new-layout.exp +++ b/gdb/testsuite/gdb.tui/new-layout.exp @@ -42,12 +42,12 @@ gdb_test "tui new-layout example src 1 src 1" \ "Window \"src\" seen twice in layout" gdb_test "tui new-layout example src 1" \ "New layout does not contain the \"cmd\" window" -gdb_test "tui new-layout example src 1}" \ - "Extra '}' in layout specification" -gdb_test "tui new-layout example {src 1} 1}" \ - "Extra '}' in layout specification" -gdb_test "tui new-layout example {src 1" \ - "Missing '}' in layout specification" +gdb_test "tui new-layout example src 1\}" \ + "Extra '\}' in layout specification" +gdb_test "tui new-layout example {src 1} 1\}" \ + "Extra '\}' in layout specification" +gdb_test "tui new-layout example \{src 1" \ + "Missing '\}' in layout specification" gdb_test_no_output "tui new-layout example asm 1 status 0 cmd 1"