From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 5D1FB3857C44 for ; Mon, 7 Sep 2020 02:53:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D1FB3857C44 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-62TMSi8LMjCUhdRHPoQl_Q-1; Sun, 06 Sep 2020 22:53:23 -0400 X-MC-Unique: 62TMSi8LMjCUhdRHPoQl_Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53A591017DC2; Mon, 7 Sep 2020 02:53:22 +0000 (UTC) Received: from f32-m1.lan (ovpn-115-29.phx2.redhat.com [10.3.115.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE6A178B32; Mon, 7 Sep 2020 02:53:21 +0000 (UTC) Date: Sun, 6 Sep 2020 19:53:21 -0700 From: Kevin Buettner To: Saagar Jha Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Rename block.{h,c} to gdb-block.{h, c} Message-ID: <20200906195321.598e166c@f32-m1.lan> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 02:53:27 -0000 On Sun, 6 Sep 2020 18:47:33 -0700 Saagar Jha wrote: > macOS, by default, uses a case-insensitive filesystem and ships with a > header in its SDK (as part of Xcode) at /usr/include/Block.h. > from Xcode 12's SDK for macOS 11 includes this file but > due to GDB's compilation flags ends up including gdb/block.h. The > simplest solution to fix the resulting build errors is to just rename it > to something that doesn't conflict. As you may have gathered in my reply to Simon, I'm not (yet) in favor of your renaming changes, but I would like to understand it better. Could you provide additional details about where things go wrong? I.e. please show the error messages and code snippets from the relevant header files... Thanks, Kevin