From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.195]) by sourceware.org (Postfix) with ESMTPS id E1F3E3948AB3 for ; Fri, 28 Aug 2020 16:23:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E1F3E3948AB3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 927944FC40 for ; Fri, 28 Aug 2020 11:23:55 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BhARkSoY1dbRzBhARkHz9U; Fri, 28 Aug 2020 11:23:55 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GYHO0aoPac81Aa591nY5s+L7irm7K2PSgogpV0R2HYQ=; b=gIRQ7+RcwWGgyPLC9iwdqXbJNn zH1HKi/AIuUtWeylTwsnWorIYsrdMc8vmiWXb+O5Bj+Q88dEOSwQf7UOZ/EE+tMbHUcQFvWc+XYSn FDu0ivbygP/HvoX8gBC6+MCJX; Received: from 71-218-12-75.hlrn.qwest.net ([71.218.12.75]:33904 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kBhAR-002WJo-Bb; Fri, 28 Aug 2020 10:23:55 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 11/13] Use gdb_bfd_sections in elf_symfile_read Date: Fri, 28 Aug 2020 10:23:47 -0600 Message-Id: <20200828162349.987-12-tom@tromey.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20200828162349.987-1-tom@tromey.com> References: <20200828162349.987-1-tom@tromey.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.218.12.75 X-Source-L: No X-Exim-ID: 1kBhAR-002WJo-Bb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-218-12-75.hlrn.qwest.net (bapiya.Home) [71.218.12.75]:33904 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 16:23:57 -0000 This changes elf_symfile_read to avoid bfd_map_over_sections, in favor of iteration. gdb/ChangeLog 2020-08-28 Tom Tromey * elfread.c (elf_locate_sections): Change parameters. (elf_symfile_read): Use foreach. --- gdb/ChangeLog | 5 +++++ gdb/elfread.c | 10 +++++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gdb/elfread.c b/gdb/elfread.c index 75bdd75250b..5dad3ddd940 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -176,11 +176,8 @@ elf_symfile_segments (bfd *abfd) -kingdon). */ static void -elf_locate_sections (bfd *ignore_abfd, asection *sectp, void *eip) +elf_locate_sections (asection *sectp, struct elfinfo *ei) { - struct elfinfo *ei; - - ei = (struct elfinfo *) eip; if (strcmp (sectp->name, ".stab") == 0) { ei->stabsect = sectp; @@ -1211,7 +1208,10 @@ elf_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags) memset ((char *) &ei, 0, sizeof (ei)); if (!(objfile->flags & OBJF_READNEVER)) - bfd_map_over_sections (abfd, elf_locate_sections, (void *) & ei); + { + for (asection *sect : gdb_bfd_sections (abfd)) + elf_locate_sections (sect, &ei); + } elf_read_minimal_symbols (objfile, symfile_flags, &ei); -- 2.17.2