Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Luis Machado <luis.machado@linaro.org>
Cc: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Reject ambiguous C++ field accesses
Date: Fri, 28 Aug 2020 15:35:56 +0100	[thread overview]
Message-ID: <20200828143556.GA15596@blade.nx> (raw)
In-Reply-To: <ea1313c5-5b3f-40dd-4986-2eca282a3f91@linaro.org>

Luis Machado wrote:
> On 8/27/20 3:02 PM, Pedro Alves wrote:
> > diff --git a/gdb/valops.c b/gdb/valops.c
> > index 0eb2b096211..0e030a03ecd 100644
> > --- a/gdb/valops.c
> > +++ b/gdb/valops.c
> > @@ -1766,25 +1766,105 @@ typecmp (int staticp, int varargs, int nargs,
> >     return i + 1;
> >   }
> > -/* Helper class for do_search_struct_field that updates *RESULT_PTR
> > -   and *LAST_BOFFSET, and possibly throws an exception if the field
> > -   search has yielded ambiguous results.  */
> > +/* Helper class for search_struct_field that keeps track of found
> > +   results.  See search_struct_field for description of
> > +   LOOKING_FOR_BASECLASS.  If LOOKING_FOR_BASECLASS is true, possibly
> > +   throws an exception if the base class search has yielded ambiguous
> 
> "throw" an exception instead?

I think remove "possibly" and "has" also.

"If LOOKING_FOR_BASECLASS is true, throw an exception if the base
class search yielded ambiguous results."

Thanks,
Gary



  reply	other threads:[~2020-08-28 14:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 18:02 Pedro Alves
2020-08-27 18:45 ` Luis Machado
2020-08-27 19:12   ` Pedro Alves
2020-08-27 19:58 ` Luis Machado
2020-08-28 14:35   ` Gary Benson [this message]
2020-08-28 20:22     ` [PATCH v2] " Pedro Alves
2020-10-12 17:12       ` Pedro Alves
2020-10-13  8:47         ` Gary Benson via Gdb-patches
2020-08-28 20:12   ` [PATCH] " Pedro Alves
2020-08-28 14:38 ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828143556.GA15596@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox