From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by sourceware.org (Postfix) with ESMTPS id 561593857C5F for ; Fri, 28 Aug 2020 08:50:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 561593857C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x442.google.com with SMTP id c15so520979wrs.11 for ; Fri, 28 Aug 2020 01:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vOVYB8dqvUm+g0O2PE8OdCLDzEAOUd0olrfz7QEtA1U=; b=bmhLtmlpnWtjdYYFi6eLvcvEp/qqirzyQH0YH+UI6DeWk0QVo7JFkO+ZP+wnSpRdjF +McDcV17/E5hgmDX/tTEX8OzkKwV3w0vc/R1EeaKxr5LRSFnlT08TD0h5r5wld2BJOV0 uqAt5fnsLOu04GUfqd8khqum0qlC06y1SixMVTEhn0Ichst1MbTD04QEQeUnRCvrARsS WRlzjEzQ+UuBFAz+8KSm4bZlYCgl2ZH1KoLHmwNPlrNy3Sf8HbhcSVkoRi4kz0mMm3Ri 9+sIgZ0P8af0YvoyaGr9gNmvnaMmFadrh5szyb9aJhK1esqnVhUHq8P856EfM4DPAwto 3hxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vOVYB8dqvUm+g0O2PE8OdCLDzEAOUd0olrfz7QEtA1U=; b=mCRfgsgTVt4CdinmfIJQDXL6dEawgQV2zO+b4aGVHPgxYeH3nzOHF8+VSlaRyckDAj ykRkyp20CKCnfmRABQPZrkX5SfswKqqJ2IfEWFxjKhi6zkY8RizCX/Nm5QI7KRj8/n+X 4/GZhevTFFG83J9+YZfRtCCfny6EHyAYHNv9dq1bznqcSy3dXuvEzMw4fMhalvrDX3LF vcnmitopSItuO+bJAfq7GuJ8k59gzmRmWAyqBRiFR6CYrk+tM0w5cpdDst6v8SYO4q2s dKFco+387kNsNrm+METDBphPQHVdgvOu3xzfPHUI5vBHNw7hjC3vjf8Xc7r+b4SrYHrY b8zw== X-Gm-Message-State: AOAM533Gfd72kXW2riRXM74Dxil4k5KWs1zfKS/0PUu5RiWywotxOp4N yWJ9zriDzKC3vRpCJYNiyk8rbg== X-Google-Smtp-Source: ABdhPJylMABwBrbqXzl4g5iKj8LSueGtzNusGfWVUPdOTiG6ynYepmjJ88+D9IvZIv7tUIgqbd1sfw== X-Received: by 2002:adf:dcc8:: with SMTP id x8mr552199wrm.16.1598604658414; Fri, 28 Aug 2020 01:50:58 -0700 (PDT) Received: from localhost (host109-152-215-54.range109-152.btcentralplus.com. [109.152.215.54]) by smtp.gmail.com with ESMTPSA id n7sm852892wrs.2.2020.08.28.01.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 01:50:57 -0700 (PDT) Date: Fri, 28 Aug 2020 09:50:56 +0100 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org, Scott.Linder@amd.com, Zoran.Zaric@amd.com Subject: Re: [PATCH v2 0/3] Support frames inlined in outer frames Message-ID: <20200828085056.GZ853475@embecosm.com> References: <20200827205724.409603-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200827205724.409603-1-simon.marchi@polymtl.ca> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 09:50:22 up 40 days, 18:04, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 08:51:00 -0000 * Simon Marchi via Gdb-patches [2020-08-27 16:57:21 -0400]: > This is essentially a v2 of this thread here: > > https://sourceware.org/pipermail/gdb-patches/2020-March/166786.html > > In summary, this is what the patches do: > > 1. fixes a latent bug that triggered when trying to unwind a frame > inlined in the outer frame > 2. changes how outer frames are represented > 3. allows frames inlined in outer frames, adds a test that runs on > regular hardware > > I don't see any regression on x86-64. I tested previous iterations of > the series (with similar code) on aarch64 too and didn't see any > regression. I took a look through all these patches, and they all look good to me. Thanks, Andrew > > Scott Linder (1): > gdb: support frames inlined into the outer frame > > Simon Marchi (2): > gdb: make frame_unwind_got_optimized return a not_lval value > gdb: introduce explicit outer frame id kind > > gdb/frame-unwind.c | 14 +- > gdb/frame-unwind.h | 3 + > gdb/frame.c | 21 +-- > gdb/frame.h | 9 +- > gdb/inline-frame.c | 4 - > .../gdb.dwarf2/dw2-reg-undefined.exp | 12 ++ > .../gdb.dwarf2/frame-inlined-in-outer-frame.S | 137 ++++++++++++++++++ > .../frame-inlined-in-outer-frame.exp | 114 +++++++++++++++ > 8 files changed, 281 insertions(+), 33 deletions(-) > create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.S > create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp > > -- > 2.28.0 >