From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 7120438708FD for ; Thu, 27 Aug 2020 16:18:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7120438708FD Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-t5I-rtVBO5mtGig7OdVs3A-1; Thu, 27 Aug 2020 12:18:53 -0400 X-MC-Unique: t5I-rtVBO5mtGig7OdVs3A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E428310ABDC3; Thu, 27 Aug 2020 16:18:51 +0000 (UTC) Received: from blade.nx (ovpn-115-0.ams2.redhat.com [10.36.115.0]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5FF95D9E8; Thu, 27 Aug 2020 16:18:51 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id D7A44816CCA9; Thu, 27 Aug 2020 17:18:50 +0100 (BST) Date: Thu, 27 Aug 2020 17:18:50 +0100 From: Gary Benson To: Pedro Alves Cc: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Enable gdb.cp/ambiguous.exp with GCC and clang Message-ID: <20200827161850.GA22365@blade.nx> References: <1597670664-14171-1-git-send-email-gbenson@redhat.com> <4b7a4f2e-9e77-495a-759b-187aebb342aa@palves.net> <20200825142146.GA14101@blade.nx> <20200827103901.GA9478@blade.nx> <20200827150741.GA18029@blade.nx> <681377e5-17f6-7bf3-1dde-3b6d85bed70f@palves.net> MIME-Version: 1.0 In-Reply-To: <681377e5-17f6-7bf3-1dde-3b6d85bed70f@palves.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 16:18:56 -0000 Pedro Alves wrote: > On 8/27/20 4:07 PM, Gary Benson wrote: > > Pedro Alves wrote: > >> On 8/27/20 11:39 AM, Gary Benson wrote: > >>> Luis Machado wrote: > >>>> I get the following, under Ubuntu 18.04 (GCC 7.x) with this commit... > >>>> > >>>> FAIL: gdb.cp/ambiguous.exp: print x.x > >>>> FAIL: gdb.cp/ambiguous.exp: print n.x > >>>> FAIL: gdb.cp/ambiguous.exp: print j.x > >>>> FAIL: gdb.cp/ambiguous.exp: print jva1.x > >>>> FAIL: gdb.cp/ambiguous.exp: print jva2.x > >>>> FAIL: gdb.cp/ambiguous.exp: print (A1)j > >>>> FAIL: gdb.cp/ambiguous.exp: print (A1)jva1 > >>>> > >>>> Is the test really supposed to run with older GCC's? > >>> > >>> Maybe not. Though, I don't know what version of GCC it ought to > >>> start working on, so it's hard to know what to do. I could leave > >>> the "-w" in for GCC < 10, and add an extra check to make it bail > >>> out for GCC <= your version, Luis? With a suitable comment to > >>> mention that that's not set in stone? > >> > >> I'm seeing it fail with GCC 9 and clang 10 as well. > >> > >> Actually, the testcase can't be working _anywhere_. It's testing a > >> feature that is gone from GDB. > > [snip] > >> ...search_struct_field does not handle the ambiguous field > >> case nowadays. Somehow it got lost over the years. > >> That seems like a regression. I wrote up a patch that adds > >> it back (though different), but it exposed other latent > >> bugs... Sigh. I'll post it soon. > > > > So the test would start passing if that patch was added? > > Should we leave the test alone, or XFAIL the cases that > > fail, or...? > > I'm adjusting / fixing the testcase at the same time as I'm > patching GDB. So for now, do nothing. Awesome, thank you. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat