From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 5329F384607A for ; Thu, 27 Aug 2020 10:39:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5329F384607A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-F-a0jbkNNcOw5GTRTBL7QQ-1; Thu, 27 Aug 2020 06:39:03 -0400 X-MC-Unique: F-a0jbkNNcOw5GTRTBL7QQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 459D7185FD7E; Thu, 27 Aug 2020 10:39:02 +0000 (UTC) Received: from blade.nx (ovpn-115-0.ams2.redhat.com [10.36.115.0]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B59B5C1C2; Thu, 27 Aug 2020 10:39:02 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 29120816CCA9; Thu, 27 Aug 2020 11:39:01 +0100 (BST) Date: Thu, 27 Aug 2020 11:39:01 +0100 From: Gary Benson To: Luis Machado Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Enable gdb.cp/ambiguous.exp with GCC and clang Message-ID: <20200827103901.GA9478@blade.nx> References: <1597670664-14171-1-git-send-email-gbenson@redhat.com> <4b7a4f2e-9e77-495a-759b-187aebb342aa@palves.net> <20200825142146.GA14101@blade.nx> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 10:39:06 -0000 Luis Machado wrote: > On 8/25/20 11:21 AM, Gary Benson via Gdb-patches wrote: > > Pedro Alves wrote: > > > On 8/17/20 2:24 PM, Gary Benson wrote: > > > > Pedro Alves wrote: > > > > > On 7/27/20 2:09 PM, Gary Benson via Gdb-patches wrote: > > > > > > + unsupported "compiler does not support -Wno-inaccessible-base" > > > > > > > > > > How about instead of bailing out, use "-Wno-inaccessible-base" > > > > > with GCC >= 10, and use "-w" with older GCCs? > > > > > > > > Sure. How about this? > > > > > > OK. > > > > Thanks, I pushed it. > > I get the following, under Ubuntu 18.04 (GCC 7.x) with this commit... > > FAIL: gdb.cp/ambiguous.exp: print x.x > FAIL: gdb.cp/ambiguous.exp: print n.x > FAIL: gdb.cp/ambiguous.exp: print j.x > FAIL: gdb.cp/ambiguous.exp: print jva1.x > FAIL: gdb.cp/ambiguous.exp: print jva2.x > FAIL: gdb.cp/ambiguous.exp: print (A1)j > FAIL: gdb.cp/ambiguous.exp: print (A1)jva1 > > Is the test really supposed to run with older GCC's? Maybe not. Though, I don't know what version of GCC it ought to start working on, so it's hard to know what to do. I could leave the "-w" in for GCC < 10, and add an extra check to make it bail out for GCC <= your version, Luis? With a suitable comment to mention that that's not set in stone? Thanks, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat