From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id 58DC63858D35 for ; Tue, 25 Aug 2020 09:36:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 58DC63858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x343.google.com with SMTP id k20so1473847wmi.5 for ; Tue, 25 Aug 2020 02:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q4haMxZ3ZSWT7uWEBej6bpvYbJv7aXex//139CLt/Sw=; b=B94T2DNfT5rwb6//UDQO/UDMplzVRGyTWGy9rKNWRxJcNrD0oQr9/o5hBwT1VluwjF R8nNO982bIFy73cNS4djdhjlVHCArLBqs1FCuefi5Onru+0vJFYnDxCohkfj4MsXEWn5 SJCWw2O4twhzKyD4E6t4atVV0BVKxAwQ+1ESANsqjfqvDnllI1jKvmt9RrhnFY969wfr 0jM7ckTDQyo3tpMW9J3oL2unOQAeeERWZul0qj6XvM2PL2QiuKfPxTGqQXy5N5fFw+4h inxe6Q6pZB3i78mGBnyYobrmbghNHx5souETUA4eI1XZEq5d0DKJVzZEOXvevGVspdpt wAoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q4haMxZ3ZSWT7uWEBej6bpvYbJv7aXex//139CLt/Sw=; b=J/T/nN90Wv9wKQNUexLd84pSNyPEJkmuCRxbJFBWQQbTLN0zmPPhvkpjbAp3ifizVm oXyTryCLDxKhlUB1amPPvajfCZVUDDXq4a7EdB+0Fo2cHPY5Wo/S9ncXnzhCfoVzG8Z2 0h7xxFiotFRDTqPyzZgGBcEPN0AuL5XfJkmZqsZGEDJL/7a9CFM2qkV3LTLjnzX4wwC4 bPkTZZ+rHxa4xSgvELvmutQqEty88VPvIL53nnYAB2XUIKSf9xY9Faa2x6328pAAdXx2 0JtwoX03ertn4lwMfTfecC0T/9gY2s0IRn3VjV1OxFlV9Icqf9Rhaf9oZSLglDo8G7kV HsTQ== X-Gm-Message-State: AOAM533sI4f56DHGsEjhu4GISk0T7hNxDmAt18CjYicBw6UotN96migj TuKvC4Dcbsv3qAz0XrVeZQBg3g== X-Google-Smtp-Source: ABdhPJy0uBFZcMSKNgRsVmzLmThTLUZOj8LukIpJ0j+MVfXxphgs9+qDOw81O4yeHptNcicBFWgAxg== X-Received: by 2002:a1c:2dd5:: with SMTP id t204mr1256429wmt.156.1598348175346; Tue, 25 Aug 2020 02:36:15 -0700 (PDT) Received: from localhost (host109-148-134-218.range109-148.btcentralplus.com. [109.148.134.218]) by smtp.gmail.com with ESMTPSA id g9sm10206746wrw.63.2020.08.25.02.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 02:36:14 -0700 (PDT) Date: Tue, 25 Aug 2020 10:36:13 +0100 From: Andrew Burgess To: Tom de Vries Cc: Gaius Mulley , gdb-patches@sourceware.org, gdb@sourceware.org Subject: Re: Patch: Fix for Bug 26372 [Modula-2] Parsing of multi-subscript arrays Message-ID: <20200825093613.GT853475@embecosm.com> References: <878se3xxtr.fsf@ettard> <9d68a12b-0df4-9ee8-540d-376f20732754@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d68a12b-0df4-9ee8-540d-376f20732754@suse.de> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 10:32:35 up 37 days, 18:47, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 09:36:17 -0000 * Tom de Vries [2020-08-25 11:29:18 +0200]: > On 8/25/20 4:29 AM, Gaius Mulley wrote: > > > > > > Hi Tom, > > > > here is a bugfix for Pr 26372 [Modula-2] Parsing of multi-subscript arrays. > > Also included is a dejagnu testcase. No extra regressions are caused on > > Debian GNU/Linux Buster amd64, is this ok to apply? > > > > Hi Gaius, > > I ran into some trouble applying the patch with the patch program, so I > applied the patch manually, and then diffed the result of that with the > original patch and fixed whitespace problems in the original patch until > I got duplicates, to ensure that the application process was sane. > > I verified that when building with the patch, the warning "rule useless > in parser due to conflicts" is gone, and no new warnings are introduced. > > I ran the test-case and verified that it failed without and passed with > the patch. > > I've also fixed the ChangeLog entry a bit (multidim.y -> multidim.exp) > and split it up for gdb/ChangeLog and gdb/testsuite/Changelog, as well > as added a PR number. > > I've gone ahead an applied it (with you as author, obviously). See > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=07758bdfa9e5a762f2ec0deeb51b11d6ad5fe376 > . > > Attached here for reference. Given the issues I raised with this patch in [1] I reverted this commit and pushed my suggested patch instead. Again maintaining the original author. I hope this does not offend anyone. Please let me know if this was the wrong course of action. Thanks, Andrew [1] https://sourceware.org/pipermail/gdb-patches/2020-August/171456.html