From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id D2D1E3858D35 for ; Mon, 24 Aug 2020 20:04:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D2D1E3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E3331117161; Mon, 24 Aug 2020 16:04:41 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YvdHvwIoSQ8T; Mon, 24 Aug 2020 16:04:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B11A0116AF3; Mon, 24 Aug 2020 16:04:41 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2894E8341B; Mon, 24 Aug 2020 13:04:40 -0700 (PDT) Date: Mon, 24 Aug 2020 13:04:40 -0700 From: Joel Brobecker To: Pedro Alves Cc: Tom de Vries , Tom Tromey , Pedro Alves via Gdb-patches Subject: Re: [PATCH 2/3] Consistently use BFD's time Message-ID: <20200824200440.GK24789@adacore.com> References: <83k104z2cb.fsf@gnu.org> <0b80b7da-d9f8-d517-920d-60572134096e@redhat.com> <87a70zvv6o.fsf@tromey.com> <87k102vm5y.fsf@tromey.com> <07179329-a5ac-6947-7303-c0d7b919aa39@redhat.com> <87ime74eta.fsf@tromey.com> <20200814234003.GA27502@adacore.com> <20200823160944.GA14567@adacore.com> <8548d40d-cf0f-482c-85d2-cfec7585d13f@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8548d40d-cf0f-482c-85d2-cfec7585d13f@palves.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 20:04:43 -0000 Hi Pedro, > >> For the short-term solution, I think the best compromise is to patch > >> gnulib like Tom suggests. We have the infrastructure to do that and > >> maintain the patch for as long as it takes to discuss the proper > >> solution (personally, I think the only way forward for the better > >> solution will require a live discussion; I am happy to help set that > >> up if people would find it useful). > > > > I discussed it live with Tom. We don't have the time to work on this > > right now, so we'll send a patch in a week or so. Given that everyone > > has had a a lot of time to provide feedback on that thread, and given > > the fact that we want to fix this before we branch, I don't think we > > want to wait too long before getting that patch in -- assuming we are > > still short on a better long term solution. > > > > FWIW, I've tried to look at this more than once the past weeks, > including today, hoping I'd find some nice solution, but all I got > was a headache. Yeah, cannot say I am surprised :-(, although I was thinking you might be in posessions of some superpowers that made you able to find a solution I couldn't. The fact that we have this hybrid situation where GDB uses gnulib but one of its depedencies doesn't makes the use of stat intractable, and if even you are having difficulties with it, I think our only realistic options are to take a more radical approach, either: - Stop using the stat module from gnulib (which I think we said we want to keep); or - Patch the gnulib implementation for now to block the incompatible behavior. The idea with this approach is that we'd try to work with gnulib maintainers to see if we could agree on a way to make the incompatibility conditional on something. That would be our way to eliminate this local change. - Something else? -- Joel