Re: [PATCH] gdb: add gdb_bfd_all_sections for range-based iteration

Tom Tromey
2020-08-24T20:31:18Z

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> I wanted to make a nicer / type-safe interface for
Simon> bfd_map_over_sections, avoiding the `void *` data parameter.

Simon> My first shot was to make a wrapper for bfd_map_over_sections,
Simon> gdb_bfd_map_over_sections that took a gdb::function_view.

Simon> However, I think that a range adapter gives nicer and simpler code, as a
Simon> simple for loop is easier to read than a callback / lambda function. So
Simon> here it is, it uses next_iterator and next_adapter, so it's not much
Simon> code.

Simon> As an example, I ported maintenance_info_sections and friends to use it.
Simon> The maint_print_section_data type could probably be removed now, but I
Simon> didn't want to do too much in one patch.

I also did this kind of thing -- I have some patches to remove many uses
of bfd_map_over_sections, though not all of them, since some seem hard
to test.

Simon> * gdb_bfd.h (gdb_bfd_section_iterator, gdb_bfd_section_range,
Simon> gdb_bfd_all_sections): New.
Simon> * maint.c (print_bfd_section_info): Change param type to
Simon> maint_print_section_data.
Simon> (print_objfile_section_info): Likewise.
Simon> (print_bfd_section_info_maybe_relocated): Likewise.
Simon> (maintenance_info_sections): Use gdb_bfd_all_sections.

Looks good. Thanks.

Tom