Re: [PATCH 2/3] Consistently use BFD's time

Tom Tromey
2020-07-28T19:31:14Z

>>>>> "Pedro" == Pedro Alves via Gdb-patches <gdb-patches@sourceware.org> writes:

Pedro> Can you clarify what do you see not work? I tried rebasing it
Pedro> here, and it seems to work. It builds cleanly on GNU/Linux and
Pedro> mingw32-w64 (both -m64 and -m32). I've pasted the resulting patch below.

What if we apply this patch, but also apply a patch to our gnulib to
avoid the timezone offsetting? We kept the code in
gnulib/update-gnulib.sh to make this pretty easy to do, and we could try
to work with upstream gnulib to make this feature optional (hopefully
eliminating the need for our patch).

This would avoid the mtime comparison problem. I don't know how to
solve that another way, at least not without changing BFD to also use
gnulib -- which seems to come with its own risks.

Once we solve this somehow, I can rebase and update the original series
here.

This is one of the final blockers to the 10.1 branch, so it would be
good to reach some kind of resolution soon.

thanks,
Tom