Re: [PATCH 2/3] Consistently use BFD's time

Pedro Alves
2020-06-18T17:32:47Z

On 6/18/20 6:27 PM, Eli Zaretskii wrote:
>> From: Tom Tromey <tom@tromey.com>
>> Cc: Tom Tromey <tom@tromey.com>, tromey@adacore.com,
>> gdb-patches@sourceware.org, palves@redhat.com
>> Date: Thu, 18 Jun 2020 10:00:57 -0600
>>
>> 2. Use --avoid=stat --avoid=fstat. So far this seems like the best
>> approach. Pedro pointed out that this means we won't get any gnulib
>> fixes for other bugs in this area. However, given gdb's relatively
>> minimal needs from stat, and given the fact that gnulib is
>> introducing other bugs, this seems like an acceptable tradeoff to me.
>
> If that works, I think it's an okay solution.

I disagree. It's not only GDB's stat usage that counts, it's the
other gnulib modules that depend on the stat module fixes too. Also,
that approach disables the stat module for all systems, not just
mingw. I think it's just bad policy to disable a module like that.

Thanks,
Pedro Alves