From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id DE6803857019 for ; Fri, 21 Aug 2020 15:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE6803857019 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x341.google.com with SMTP id o21so2323508wmc.0 for ; Fri, 21 Aug 2020 08:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5ruLmOBQEiK3YNrhQmauE5IdNLsGvXp1nc+uvH2xNbo=; b=EVRoAmnBfLDMScZa/GWTgPNOL1KEihGN+bxDhSQOkN06kQcuiJVYPoRUnobzIHmB9w xXYvSU8uN6QZPyDkJRHNG6c7qWyz1nY7Td4JIJMU3yYOKen2VuGftOYPwfX59SXoRkV2 E+CB+Ue8aD/obFGVrrwZYXXRrDokGPimqr3C8V/mG3UTw01FK7eVglMGmiMzx83VwC4u yyCz+OqYpZeZQXeVURwxeV++udgC8ac5EzDXit1y6v9iX/K8Wrw42r4IWqR3HayFHgco oneayIqZAXT3oIbNOxfEtqoMNFQAem3ItDTH19W4ldnY1RPDkSiJHeEitYoxtSiaO264 vk3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5ruLmOBQEiK3YNrhQmauE5IdNLsGvXp1nc+uvH2xNbo=; b=J6Eh80VBTQPEWoCu80DQwXmtgiPBeFTl35A1LmkeHTRrdET2hBK0MISMo7G9A4K/0Y vnwLrIAHHSslgfUJ6ISDV2iiyzCN2TxRXxd4aDbzlC+Xr6PvC2nq1Ayb9Oz6BnSeDa6M rPzV9RsOitWuP68WgdcTV+Fqy795WkWDrYylyttF46iAgGUkxMO+pniBtTEe6rzH8Y5k 8qotnPFcCM+cpbMVQIMvpawEkCjjYTw0SsKVdqSbv4x7V8lktQVqZB3CBv8355CZtezD 2kjsZAR5Nok6YxV46PZXxFCmNFBbaG4Fb69wa8uFeeau7yxHO3EpBKfFTwBXhT3p2Fd8 vzUg== X-Gm-Message-State: AOAM533srvYDH6BIHl/Zyb/u7Z65OgY/V9iyvi53UAhYOIC99LMZJ0YF NIRSXCSmsb5bHWNvEIDvF2s2EDphdgJ1IA== X-Google-Smtp-Source: ABdhPJwvuw4egDd5ocY64zL+Jw9TCAE2Rp+l5nvJBDZMSeDfaI1Yl0/PrphJkn4gwwMF1KyQbYn8BA== X-Received: by 2002:a1c:1bc2:: with SMTP id b185mr3451220wmb.168.1598025070011; Fri, 21 Aug 2020 08:51:10 -0700 (PDT) Received: from localhost (host86-140-92-120.range86-140.btcentralplus.com. [86.140.92.120]) by smtp.gmail.com with ESMTPSA id k13sm6014693wmj.14.2020.08.21.08.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2020 08:51:09 -0700 (PDT) Date: Fri, 21 Aug 2020 16:51:08 +0100 From: Andrew Burgess To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Rewrite enum_flags, add unit tests, fix problems Message-ID: <20200821155108.GO853475@embecosm.com> References: <20200821144523.19451-1-pedro@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821144523.19451-1-pedro@palves.net> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 16:50:43 up 34 days, 1:05, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2020 15:51:13 -0000 * Pedro Alves [2020-08-21 15:45:20 +0100]: > This is an update of a version of this series that I posted back in > 2016: > > [PATCH 0/3] enum_flags: Fix problems and add comprehensive unit tests > https://sourceware.org/legacy-ml/gdb-patches/2016-11/msg00079.html > > But I never followed thorough with it, leaving it collecting dust on > my github. Over the following years, I polished it and tweaked it > further and extended the unit tests, but never managed to re-submit it > all upstream. > > Since the subject of enum_flags came up again this week, I thought I'd > try it again. This is the result. Thanks for doing this work. I've only skimmed through, but it looks good. Thanks, Andrew > > Pedro Alves (3): > Rewrite valid-expr.h's internals in terms of the detection idiom > (C++17/N4502) > Use type_instance_flags more throughout > Rewrite enum_flags, add unit tests, fix problems > > gdb/Makefile.in | 1 + > gdb/btrace.c | 4 +- > gdb/compile/compile-c-types.c | 3 +- > gdb/compile/compile-cplus-symbols.c | 4 +- > gdb/compile/compile-cplus-types.c | 10 +- > gdb/dwarf2/read.c | 7 +- > gdb/eval.c | 2 +- > gdb/gdbarch.c | 6 +- > gdb/gdbarch.h | 12 +- > gdb/gdbarch.sh | 8 +- > gdb/gdbtypes.c | 58 ++-- > gdb/gdbtypes.h | 15 +- > gdb/go-exp.y | 2 +- > gdb/record-btrace.c | 10 +- > gdb/stabsread.c | 2 +- > gdb/type-stack.c | 4 +- > gdb/unittests/enum-flags-selftests.c | 586 +++++++++++++++++++++++++++++++++++ > gdbsupport/enum-flags.h | 366 +++++++++++++++++----- > gdbsupport/traits.h | 67 ++++ > gdbsupport/valid-expr.h | 35 ++- > 20 files changed, 1035 insertions(+), 167 deletions(-) > create mode 100644 gdb/unittests/enum-flags-selftests.c > > > base-commit: b70e516e89d95d06252cb04ded3397ec0a0a3212 > -- > 2.14.5 >