From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D86363858D37 for ; Mon, 17 Aug 2020 20:57:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D86363858D37 Date: Mon, 17 Aug 2020 21:57:41 +0100 From: Sergei Trofimovich To: Simon Marchi Cc: Kevin Buettner , Sergei Trofimovich , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: fix IA64 build failure of linux-nat Message-ID: <20200817215741.4f2a4be0@sf> In-Reply-To: References: <20200519212710.1417100-1-slyfox@gentoo.org> <20200519150041.13df2b38@f31-4.lan> <20200816094521.061554bb@sf> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/l201ZbovEUrKp.TFC5_tuaq" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 20:57:48 -0000 --MP_/l201ZbovEUrKp.TFC5_tuaq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Sun, 16 Aug 2020 17:51:28 -0400 Simon Marchi wrote: > On 2020-08-16 4:45 a.m., Sergei Trofimovich via Gdb-patches wrote: > > On Tue, 19 May 2020 15:00:41 -0700 > > Kevin Buettner wrote: > > > >> On Tue, 19 May 2020 22:27:10 +0100 > >> Sergei Trofimovich via Gdb-patches wrote: > >> > >>> From: Sergei Trofimovich > >>> > >>> On IA64 built failed as: > >>> > >>> ``` > >>> ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope > >>> 352 | if (regno < 0 || regno >= gdbarch_num_regs (gdbarch)) > >>> | ^~~~~~~~~~~~~~~~ > >>> ``` > >>> > >>> The fix includes "gdbarch.h" header where symbol is declared. > >>> > >>> * gdb/ia64-linux-nat.c: include "gdbarch.h" to declare used > >>> 'gdbarch_num_regs'. > >> > >> Okay, but please capitalize "include" in the ChangeLog entry prior > >> to pushing this change. > > > > Attached v2-* patch with capitalization changes. > > > > I don't have a 'gdb' write access yet (I think), but I do have GCC one. > > > > Should I request 'gdb' access as well as specified in > > https://sourceware.org/cgi-bin/pdw/ps_form.cgi ? > > Yes, that would be useful if you plan on contributing regularly. If it's just > a occasional patch, we can also push for you. As you wish. Sounds good! Got write access granted. > > > > Thank you for the review! > > A few more styling nits: > > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > > index 9cc7e44cba7..8865e6949d6 100644 > > --- a/gdb/ChangeLog > > +++ b/gdb/ChangeLog > > @@ -4564,6 +4564,11 @@ > > > > * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open. > > > > +2020-05-19 Sergei Trofimovich > > + > > + * gdb/ia64-linux-nat.c: Include "gdbarch.h" to declare used > > + 'gdbarch_num_regs'. > > The file path should be relative to the ChangeLog location, so here just "ia64-linux-nat.c". > > Also, make sure that your new entry is at the top of the file (here, it's at line 4564), and > that you update the date to $TODAY when you push. For these reasons, most people don't include > the ChangeLog bits in the patch directly, but just include it in the commit log (as you did). > Of course, when pushing the patch, then you need to insert it in the ChangeLog file. All makes sense! Attached v3-* patch with date and path in ChanegLog change. -- Sergei --MP_/l201ZbovEUrKp.TFC5_tuaq Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=v3-0001-gdb-fix-IA64-build-failure-of-linux-nat.patch >From f9b11e6b1833a6dc06a0af03bcb6bd42d7a2f009 Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Tue, 19 May 2020 22:19:45 +0100 Subject: [PATCH v3] gdb: fix IA64 build failure of linux-nat On IA64 built failed as: ``` ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope 352 | if (regno < 0 || regno >= gdbarch_num_regs (gdbarch)) | ^~~~~~~~~~~~~~~~ ``` The fix includes "gdbarch.h" header where symbol is declared. * ia64-linux-nat.c: Include "gdbarch.h" to declare used 'gdbarch_num_regs'. Signed-off-by: Sergei Trofimovich --- gdb/ChangeLog | 5 +++++ gdb/ia64-linux-nat.c | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b097b325a22..3f681e19e5a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-08-17 Sergei Trofimovich + + * ia64-linux-nat.c: Include "gdbarch.h" to declare used + 'gdbarch_num_regs'. + 2020-08-17 Tom Tromey * ada-varobj.c (ada_varobj_decode_var): Handle case where diff --git a/gdb/ia64-linux-nat.c b/gdb/ia64-linux-nat.c index 8f36ea78e76..b532e7a51c5 100644 --- a/gdb/ia64-linux-nat.c +++ b/gdb/ia64-linux-nat.c @@ -21,6 +21,7 @@ #include "defs.h" #include "inferior.h" #include "target.h" +#include "gdbarch.h" #include "gdbcore.h" #include "regcache.h" #include "ia64-tdep.h" -- 2.28.0 --MP_/l201ZbovEUrKp.TFC5_tuaq--