From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 3C5143860C33 for ; Sun, 16 Aug 2020 08:45:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3C5143860C33 Date: Sun, 16 Aug 2020 09:45:21 +0100 From: Sergei Trofimovich To: Kevin Buettner Cc: gdb-patches@sourceware.org, Sergei Trofimovich Subject: Re: [PATCH] gdb: fix IA64 build failure of linux-nat Message-ID: <20200816094521.061554bb@sf> In-Reply-To: <20200519150041.13df2b38@f31-4.lan> References: <20200519212710.1417100-1-slyfox@gentoo.org> <20200519150041.13df2b38@f31-4.lan> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/7R0br_PFJT+5074BXnMoTb." X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 08:45:27 -0000 --MP_/7R0br_PFJT+5074BXnMoTb. Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, 19 May 2020 15:00:41 -0700 Kevin Buettner wrote: > On Tue, 19 May 2020 22:27:10 +0100 > Sergei Trofimovich via Gdb-patches wrote: > > > From: Sergei Trofimovich > > > > On IA64 built failed as: > > > > ``` > > ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope > > 352 | if (regno < 0 || regno >= gdbarch_num_regs (gdbarch)) > > | ^~~~~~~~~~~~~~~~ > > ``` > > > > The fix includes "gdbarch.h" header where symbol is declared. > > > > * gdb/ia64-linux-nat.c: include "gdbarch.h" to declare used > > 'gdbarch_num_regs'. > > Okay, but please capitalize "include" in the ChangeLog entry prior > to pushing this change. Attached v2-* patch with capitalization changes. I don't have a 'gdb' write access yet (I think), but I do have GCC one. Should I request 'gdb' access as well as specified in https://sourceware.org/cgi-bin/pdw/ps_form.cgi ? Thank you for the review! -- Sergei --MP_/7R0br_PFJT+5074BXnMoTb. Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=v2-0001-gdb-fix-IA64-build-failure-of-linux-nat.patch >From 0357a5913eb9232d9a29a7e1b2c90d3a03a1ae2b Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Tue, 19 May 2020 22:19:45 +0100 Subject: [PATCH v2] gdb: fix IA64 build failure of linux-nat On IA64 built failed as: ``` ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope 352 | if (regno < 0 || regno >= gdbarch_num_regs (gdbarch)) | ^~~~~~~~~~~~~~~~ ``` The fix includes "gdbarch.h" header where symbol is declared. * gdb/ia64-linux-nat.c: Include "gdbarch.h" to declare used 'gdbarch_num_regs'. Signed-off-by: Sergei Trofimovich --- gdb/ChangeLog | 5 +++++ gdb/ia64-linux-nat.c | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9cc7e44cba7..8865e6949d6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -4564,6 +4564,11 @@ * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open. +2020-05-19 Sergei Trofimovich + + * gdb/ia64-linux-nat.c: Include "gdbarch.h" to declare used + 'gdbarch_num_regs'. + 2020-05-19 Simon Marchi * dwarf2/read.c (quirk_rust_enum): Allocate enough fields. diff --git a/gdb/ia64-linux-nat.c b/gdb/ia64-linux-nat.c index 8f36ea78e76..b532e7a51c5 100644 --- a/gdb/ia64-linux-nat.c +++ b/gdb/ia64-linux-nat.c @@ -21,6 +21,7 @@ #include "defs.h" #include "inferior.h" #include "target.h" +#include "gdbarch.h" #include "gdbcore.h" #include "regcache.h" #include "ia64-tdep.h" -- 2.28.0 --MP_/7R0br_PFJT+5074BXnMoTb.--