On Tue, 19 May 2020 15:00:41 -0700
Kevin Buettner <kevinb@redhat.com> wrote:

> On Tue, 19 May 2020 22:27:10 +0100
> Sergei Trofimovich via Gdb-patches <gdb-patches@sourceware.org> wrote:
> 
> > From: Sergei Trofimovich <siarheit@google.com>
> > 
> > On IA64 built failed as:
> > 
> > ```
> > ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope
> >   352 |   if (regno < 0 || regno >= gdbarch_num_regs (gdbarch))
> >       |                             ^~~~~~~~~~~~~~~~
> > ```
> > 
> > The fix includes "gdbarch.h" header where symbol is declared.
> > 
> > 	* gdb/ia64-linux-nat.c: include "gdbarch.h" to declare used
> > 	'gdbarch_num_regs'.  
> 
> Okay, but please capitalize "include" in the ChangeLog entry prior
> to pushing this change.

Attached v2-* patch with capitalization changes.

I don't have a 'gdb' write access yet (I think), but I do have GCC one.

Should I request 'gdb' access as well as specified in
    https://sourceware.org/cgi-bin/pdw/ps_form.cgi ?

Thank you for the review! 

-- 

  Sergei