From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id A7E7F386F810 for ; Sun, 16 Aug 2020 09:08:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A7E7F386F810 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x441.google.com with SMTP id r2so12000423wrs.8 for ; Sun, 16 Aug 2020 02:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nF4c0NOicl9LSs5e1mMUiDrwLV8tfY62M6UpkOfw16w=; b=EDZFwQOvQRbMWheluATJxkhvdnU5E6q2kPKjzKE7cDiSeLBuDhIyB5XespuieqVjh5 1mdkiOTZGmh8yKomEUpeBxll2+k6Vjx/9CyN8sSrkVeqD7tcc6GPMiTfMJsWNdrCH/8i zHFpCOvYLzjGzTkt9mMaw9MUmlUXnj5gqtnf4FcYgsWHAE32Q3gMuA8UtJxRbj1rjKJH dgcqvGivyBkqsZy84S0Jn46bPCPZH6KSR19y1XtGrKl8919aBSLkJPDCt4h1T608+nXU 8efCTu9SoAMb+JkIpI/1ydblQLyZQFM6Bs5K/xgQDALFrFnkQ5x8A2pHnyBI3VzYJwUW n40Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nF4c0NOicl9LSs5e1mMUiDrwLV8tfY62M6UpkOfw16w=; b=pyuIuYdPX2eUEUgkbhw3aw7bHWQfG36LVbiEEXS1R6U+cKXRdH+KSoe5tcaYfT+JYn kGaUq34yfqPvGcWeJ60dSKCJlvgKt5wqMIIyM9PAdhx3yj6aAcqm5Ok5LMOgjFE1ypcX 9FJ94fViRFKc/V+ru+ob1HBLjvn0Wx873yuU+tlSsRASnL/M6I5/YKKscysMj0wOWNKc wih3NOITm95o7LqjmvBYu1Dl096+FN4ARRPsYjz4nE0gu6V7niqy+02/Q/wBX1CuZgrg azKs3ZE2CiHZa8jkYT526+7exPJlR9T55UFpuw28JOyhUbF7kpDr8exIbhn/YNMa7ZzN RFfg== X-Gm-Message-State: AOAM5302xteOAKsGO2mKEJQQmwXokOiUfQu5xtoTEC82/34q9voWHbsE jLSRt883CbVVyT4atqRQnK+U4kwhwzPEsg== X-Google-Smtp-Source: ABdhPJwBWunLFHXphg2kf5KlI1c3JMQ4xLg6tT1APC7xefveNBf6PMh695Ri9LWMRAqSwirZAVQWIA== X-Received: by 2002:adf:c64d:: with SMTP id u13mr10424009wrg.114.1597568930830; Sun, 16 Aug 2020 02:08:50 -0700 (PDT) Received: from localhost (host86-186-80-213.range86-186.btcentralplus.com. [86.186.80.213]) by smtp.gmail.com with ESMTPSA id n11sm19214345wmi.15.2020.08.16.02.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2020 02:08:50 -0700 (PDT) Date: Sun, 16 Aug 2020 10:08:48 +0100 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/8] gdbsupport: Make function arguments constant in enum-flags.h Message-ID: <20200816090848.GH853475@embecosm.com> References: <44267df2ec496c918c09467d28770f366de15ba5.1597319264.git.andrew.burgess@embecosm.com> <875z9jhevk.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875z9jhevk.fsf@tromey.com> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 10:08:28 up 28 days, 18:23, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 09:08:53 -0000 * Tom Tromey [2020-08-15 13:45:51 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Make the arguments used for the operators within enum-flags.h constant > Andrew> references where possible. There should be no user visible changes > Andrew> after this commit. > > enum_flags is a standard layout value-like class. Normally the compiler > will be able to treat objects of this type as if they were the > underlying scalar type -- there will be no abstraction penalty, the > object will be passed in registers, etc. > > So, I think it's best not to use references here, unless there's a > strong reason for it. Thanks for the feedback. This patch can be dropped from the series. Andrew