Re: [PATCH] Work around incorrect/broken pathnames in NT_FILE note

[Kevin Buettner <kevinb@redhat.com>]

On Sun, 9 Aug 2020 01:19:43 -0700
Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org> wrote:

> That new failure is expected in your docker environment.  It might
> be possible to XFAIL it.  We need to be able to detect that we're
> running in docker with the AUFS storage driver.  Since we know that
> the kernel is leaking docker host paths, we should see these when the
> "info proc mappings" command is used with a loaded core file.  I'll
> give it a try...

It turned out that there's an even easier way to XFAIL this case.
See below...

From 23452e31502820e15c1c72a3935360f7f1932ed9 Mon Sep 17 00:00:00 2001
From: Kevin Buettner <kevinb@redhat.com>
Date: Tue, 11 Aug 2020 09:36:12 -0700
Subject: [PATCH] corefile.exp: XFAIL warning-free test when testing on docker

When testing on docker using the AUFS storage driver, loading a core
file will often print a number of warnings.  Here's an example (with
the pathname shortened somewhat):

warning: Can't open file /var/lib/docker/aufs/diff/d07..e21/lib/x86_64-linux-gnu/libc-2.27.so during file-backed mapping note processing

The "warning-free" test in gdb.base/corefile.exp will fail if any
warnings are printed, but this particular warning is unavoidable when
running in the docker environment.  Fortunately, the path mentions
both "docker" and "aufs", making it easy to XFAIL this case.

gdb/testsuite/ChangeLog:

	* gdb.base/corefile.exp (warning-free): XFAIL test when running
	on docker w/ AUFS storage driver.
---
 gdb/testsuite/gdb.base/corefile.exp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp
index 8abf62b51f..b1022dd16f 100644
--- a/gdb/testsuite/gdb.base/corefile.exp
+++ b/gdb/testsuite/gdb.base/corefile.exp
@@ -324,11 +324,18 @@ corefile_test_attach
 # Test warning-free core file load.  E.g., a Linux vDSO used to
 # trigger this warning:
 #     warning: Can't read pathname for load map: Input/output error.
+#
+# When testing in a docker container using the AUFS storage driver,
+# the kernel places host paths in the core file's NT_FILE note.  XFAIL
+# this case since these paths make no sense in the container.
 
 clean_restart ${testfile}
 
 set test "core-file warning-free"
 gdb_test_multiple "core-file $corefile" $test {
+    -re "warning: Can\'t open file.*\/docker\/aufs\/.*\r\n$gdb_prompt $" {
+	xfail $test
+    }
     -re "warning: .*\r\n.*\r\n$gdb_prompt $" {
 	fail $test
     }