From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 433753858D35 for ; Fri, 7 Aug 2020 22:43:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 433753858D35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-B59ba2PZPeSFfT4ee_tv7g-1; Fri, 07 Aug 2020 18:43:11 -0400 X-MC-Unique: B59ba2PZPeSFfT4ee_tv7g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E865800688; Fri, 7 Aug 2020 22:43:10 +0000 (UTC) Received: from f32-m1.lan (ovpn-112-15.phx2.redhat.com [10.3.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 792645D9CA; Fri, 7 Aug 2020 22:43:10 +0000 (UTC) Date: Fri, 7 Aug 2020 15:43:08 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 00/24] Multi-target support Message-ID: <20200807154308.5d30cdf5@f32-m1.lan> In-Reply-To: References: <20191017225026.30496-1-palves@redhat.com> <20200803203000.7b559c7c@f32-m1.lan> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 22:43:18 -0000 On Thu, 6 Aug 2020 16:16:10 +0100 Pedro Alves wrote: > On 8/4/20 4:30 AM, Kevin Buettner via Gdb-patches wrote: > > On Fri, 10 Jan 2020 20:13:22 +0000 > > Pedro Alves wrote: > > > >> I've now merged the multi-target work to master, including > >> the couple follow up patches developed and discussed on this > >> thread. > > > > I've run into a regression stemming from this commit: > > > > 5b6d1e4fa4 (HEAD, refs/bisect/bad) Multi-target support > > > > More info in Bug 26336: > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=26336 > > > > (I thought at first that I introduced this problem with my recent > > core file work, but realized that was not the case after I disabled > > it. I then did a bisection starting from late last year.) > > Thanks for the bisect and the initial analysis. This patch fixes > it for me. No regressions for me on either -m32 nor -m64, and > the corefile.exp regression is fixed. Let me know what you think. Your analysis make sense to me and the patch looks good. I've tested your patch locally and no longer see the corefile.exp regression when testing w/ x86_64/-m32 (or with just x86_64). Kevin