Re: [committed] MSP430: sim: Increase main memory region size

[Jozef Lawrynowicz <jozef.l@mittosystems.com>]

Hi,

On Fri, Aug 07, 2020 at 06:32:29AM -0600, Tom Tromey wrote:
> >>>>> "Jozef" == Jozef Lawrynowicz <jozef.l@mittosystems.com> writes:
> 
> I don't know much about MSP430 or the sim, but I noticed a little
> oddity:
> 
> Jozef> The area between 0xFF00 and 0xFFC0 is unallocated in the simulator
> Jozef> memory map, so extend the main memory region up to 0xFFC0 to allow the
> Jozef> simulator to make use of the extra 192 bytes of space.
> 
> The intro text says 0xFFC0...
> 
> Jozef> +    sim_do_commandf (sd, "memory-region 0x500,0xfac0");  /* RAM and/or ROM */
> 
> ... but the patch says 0xfac0.  I think one or the other should be
> changed.

The memory-region command takes an origin address and size as arguments,
in the same way a linker script memory map does.

So 0xfac0 is not the end of the region, but the size of the region, and
of course 0x500 + 0xfac0 = 0xffc0.

Thanks,
Jozef
> 
> Tom