From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id 52E95385DC14 for ; Tue, 4 Aug 2020 13:41:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 52E95385DC14 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x441.google.com with SMTP id f1so36904735wro.2 for ; Tue, 04 Aug 2020 06:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=swjlhvQ8Z675Y96A7R+hfSf5gDDahUBQmyVbHM1KbYA=; b=FSJx7eC6FBNLXLD2oyOD1CZshQbaHSSgmAS13rDZTl0IuxkmcolIxOLFgSbJPaqWhK G9dKhMLeAetljy2oNIpnhQcE9YD8rXI0KWN53mtMoUxekh6By1WEwbqfgcLYNezotu5+ iyknjrSO8thRwC6CU6I8E+YzGz5X2CVxrym4KBMntWY1ZNwQYLyg0e03KKy9SYEzjp/p joFoBxiy+a0mX59MPkNSuZOVZUNgVEAKQUz5hF/Siv0BhFCSIxPKYK5Ut01emPTSAzQP LpokSJ3IOVdGOH2a8sFyooruouxCZjbArQw6mBpbsVAXVxJ1JGnwpD64tgwUdJShkThn mXjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=swjlhvQ8Z675Y96A7R+hfSf5gDDahUBQmyVbHM1KbYA=; b=d/9ys2srs58RGzoK1YFHmz4hbL9ZIWnWg5jcXn9MB2CzW2mOVmve23IEz8wOXGFJIa I1/KJ2EnPbVL+UYHJh8xGJmqsEq9LVoHTgtZmds4bEMw4kuo9055HCAwdb77lvaqRJfD gclYamaEut4gj05qn/yUiNtPuHpeDBwWOiI0y90X1ScOi508/uH4dtd6AYKSybZUlliA kh7uhY0sXxZd80RR/rgp09dziYbE7WdVzRH399TVFi90rP88zq3htj7lkgOYaOladQo1 JE1WWjSVo2Xj+ouVarQ51u2VD3IHvgLCus3yNYVk6frFP1LOJTsFEIMZ4Za+z04BYhrc 2ORA== X-Gm-Message-State: AOAM532Z9lQXFkVa1pnlBQvJlXPWRK16V1J+eKn7BUE+RsnFZjgco7f2 DVQ+NEAp6ZuFOQKDWbL46+yC7Q== X-Google-Smtp-Source: ABdhPJzmjg8OlzAGFtKYeE3mtUr0aAMVgaHPtDnBvORAxXvO8PM/X4CotcXBxK31AD7fySoXDUWfig== X-Received: by 2002:adf:ee06:: with SMTP id y6mr19596750wrn.225.1596548517451; Tue, 04 Aug 2020 06:41:57 -0700 (PDT) Received: from localhost (host86-140-161-92.range86-140.btcentralplus.com. [86.140.161.92]) by smtp.gmail.com with ESMTPSA id l81sm4693448wmf.4.2020.08.04.06.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 06:41:55 -0700 (PDT) Date: Tue, 4 Aug 2020 14:41:54 +0100 From: Andrew Burgess To: "Jose E. Marchesi" Cc: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" Subject: Re: [PATCH V6 1/3] gdb: support for eBPF Message-ID: <20200804134154.GV853475@embecosm.com> References: <20200803140237.14476-1-jose.marchesi@oracle.com> <20200803140237.14476-2-jose.marchesi@oracle.com> <87o8nrengw.fsf@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o8nrengw.fsf@oracle.com> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 14:38:39 up 16 days, 22:53, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2020 13:42:00 -0000 * Jose E. Marchesi via Gdb-patches [2020-08-03 17:52:15 +0200]: > > Hello. > > > On Monday, August 3, 2020 4:03 PM, Jose E. Marchesi wrote: > >> This patch adds basic support for the eBPF target: tdep and build > >> machinery. The accompanying simulator is introduced in subsequent > >> patches. > >> > >> +/* Internal debugging facilities. */ > >> + > >> +/* When this is set to non-zero debugging information will be > >> + printed. */ > >> + > >> +static unsigned int bpf_debug_flag = 0; > >> + > >> +/* The show callback for 'show debug bpf'. */ > >> + > >> +static void > >> +show_bpf_debug (struct ui_file *file, int from_tty, > >> + struct cmd_list_element *c, const char *value) > > > > Just my two cents. The 'struct' keyword can be removed in numerous places > > throughout the file. Also, NULL can be replaced with nullptr. > > I prefer to write (and maintain) C. GDB is written in C++. Though it's C history shows in many places, the code base is ever moving towards C++, IMHO new code should be quality C++. Thanks, Andrew