Re: [PATCH 0/9] Remove some macros from exec.h and progspace.h

Simon Marchi
2020-07-22T12:38:50Z

On 2020-07-21 11:34 p.m., Tom Tromey wrote:
> This series removes some macros from exec.h and progspace.h. In
> particular, macros that hide that some global variable is used are
> removed.
>
> I find these macros somewhat obscure. I think patches #2 and #6 show
> why -- it turns out that some code here was easily parameterized and
> did not need to use a global, or even save/restore the current program
> space.
>
> Let me know what you think. Like the other series along these lines,
> I don't see any need to check them in before the branch is made.

Thanks for doing this! That makes the dependency on current_program_space
more apparent. I'm sure in many cases it will be possible to change the
reference to current_program_space to be a parameter, your patch enables
that.

Simon