From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 15D993861896 for ; Wed, 22 Jul 2020 04:15:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 15D993861896 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-eJriWYGCMtyPKaq1FXYINg-1; Wed, 22 Jul 2020 00:15:12 -0400 X-MC-Unique: eJriWYGCMtyPKaq1FXYINg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B10510059D0; Wed, 22 Jul 2020 04:15:11 +0000 (UTC) Received: from f32-m1.lan (ovpn-112-21.phx2.redhat.com [10.3.112.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB7B379310; Wed, 22 Jul 2020 04:15:10 +0000 (UTC) Date: Tue, 21 Jul 2020 21:15:10 -0700 From: Kevin Buettner To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdbserver: handle running threads in qXfer:threads:read Message-ID: <20200721211510.70c99462@f32-m1.lan> In-Reply-To: <20200722014324.23166-1-pedro@palves.net> References: <20200722014324.23166-1-pedro@palves.net> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 04:15:18 -0000 On Wed, 22 Jul 2020 02:43:24 +0100 Pedro Alves wrote: > On some systems, the gdb.multi/multi-target.exp testcase occasionally > fails... I've applied your patch on my local machines and have run the following command repeatedly on builds on F28, F31, F32, and Rawhide: make check RUNTESTFLAGS="--target_board unix" TESTS="gdb.multi/multi-target.exp" Each test run on all four machines reports: # of expected passes 486 To put this in context, I never saw that result on the machines in question without your patch. Without your patch, there were *always* unexpected failures and untested testcases and, moreover, the numbers reported would frequently vary from one run to the next. So, a definite (and very welcome) improvement! Kevin