From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 2CEE0393BC38 for ; Fri, 17 Jul 2020 15:52:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2CEE0393BC38 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271--oyH2cgxPaubAupQPygTTw-1; Fri, 17 Jul 2020 11:52:36 -0400 X-MC-Unique: -oyH2cgxPaubAupQPygTTw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A42D8800400; Fri, 17 Jul 2020 15:52:35 +0000 (UTC) Received: from blade.nx (ovpn-113-199.ams2.redhat.com [10.36.113.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id 467151A7C8; Fri, 17 Jul 2020 15:52:35 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 736F1816CCA9; Fri, 17 Jul 2020 16:52:34 +0100 (BST) Date: Fri, 17 Jul 2020 16:52:34 +0100 From: Gary Benson To: Andrew Burgess Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages Message-ID: <20200717155234.GA14545@blade.nx> References: <2d73efe4dc489f06fd4e67aa18979e5b655b7100.1594198122.git.andrew.burgess@embecosm.com> <20200708100600.GA10907@blade.nx> <0ceca48f-a952-ceb3-eb4c-09c65f11bdf3@simark.ca> <20200715093630.GE2737@embecosm.com> MIME-Version: 1.0 In-Reply-To: <20200715093630.GE2737@embecosm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 15:52:40 -0000 Andrew Burgess wrote: > * Simon Marchi [2020-07-14 22:06:05 -0400]: > > On 2020-07-08 6:06 a.m., Gary Benson via Gdb-patches wrote: > > > This is potentially bikeshedding, but should the i386 in this > > > line be enclosed in quotes also? > > > > This is not bikeshedding, IMO. Consistency and attention to > > details make a tool look much better! > > I agree, and I'm always happy to get feedback like this. > > FYI - this change made it into the final patch I merged. Oh, awesome, thank you! Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat