From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 04A233857C59 for ; Fri, 17 Jul 2020 09:44:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 04A233857C59 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x341.google.com with SMTP id o8so13986110wmh.4 for ; Fri, 17 Jul 2020 02:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=12Zk/xET8FBeYG/4eqCfiWUj7ZRN0UuPv78qMhSPQIA=; b=avHd1CuSrTRAsSo/ewLXZLwAu4Iv6/Wk8yJ3QKagXWNKw29RkI8gvtVJIRbfnsgWCU xP/t/3I4b/MUZ5N7LNJNsRUeM5dbnHKuADyxDDYiIdTmdSHI5K2R6BgC8zd+D6+DqHFn gdyhqm/c8KqkUxedckcOuyF3BiCsM5pX85yokUwVUjHCfMsJ+I+2LDXPHbySPOvcOxnb qD5TPFyvW2aG0GFS9KVNZiSO4d6dUQyMOKBmaAUAm0v2oruwjT5tgh4m8M3eMWpEwdvv nodTTdOtlYFHlx/LN0cRwgTxOMUOoMa6eFQnCT9bRqxiTvS5pejL6it9gtb4gj5EJYcl vMeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=12Zk/xET8FBeYG/4eqCfiWUj7ZRN0UuPv78qMhSPQIA=; b=uiBZuRbfnNYySEz+l7Mv9FfMOegHtZstTESacNWEMSBT2JVbfKxZajoxGL4NwHUBD3 fqEizuohzNIwPE/lP8CVmA2Fu/mfn5CCLkAOIP99PW31224GUcxliHnswC45W/0n6Iwd SxBorzXDG3ifHXDM5penR2e+BGbiiSMJBpU/L+TxS0r4w3mL68kYlkO6LPQbGn3v1kbT 2m6BoJ36vwWuqqWBPsAScldqks7RVyPdDT+X1w4s27AE/g6ToQtzrFRf1U0X3IY3MTgw l7/WJjgYy4ti+ipmhktyDsdrExvv18ErQCRqCf+6L1T4bzEDTN6oFXj4jWuHELtZon+t z1XA== X-Gm-Message-State: AOAM533vXWIxk4uenxvIkA3I60hYemk5SVtBNG+R+h4DdaPq3bmqEpoM OoJTEuiTs62eQH1V8SpLznbNMg== X-Google-Smtp-Source: ABdhPJxEo2CV4zvwcjGp4X5dYEb7eEFAjbaPHitJ5EWt/2C6CNsfj3u9IoZTgIJzHl+xzSghiIN9eA== X-Received: by 2002:a1c:9e4c:: with SMTP id h73mr8996536wme.177.1594979040078; Fri, 17 Jul 2020 02:44:00 -0700 (PDT) Received: from localhost (host86-128-12-23.range86-128.btcentralplus.com. [86.128.12.23]) by smtp.gmail.com with ESMTPSA id m16sm13875547wro.0.2020.07.17.02.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 02:43:59 -0700 (PDT) Date: Fri, 17 Jul 2020 10:43:58 +0100 From: Andrew Burgess To: Caroline Tice Cc: Tom Tromey , Eric Christopher , Simon Marchi , Caroline Tice via Gdb-patches , Joseph Myers Subject: Re: [PATCH] Update testsuite mechanism to allow object files as source files. Message-ID: <20200717094358.GK2737@embecosm.com> References: <87ft9rmd7c.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 10:38:44 up 38 days, 23:45, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 09:44:02 -0000 * Caroline Tice via Gdb-patches [2020-07-16 14:10:25 -0700]: > Has the DWARF assembler in the GDB testsuite been updated to handle > DWARF v5? Or can it handle that automatically? Is there a good > example I can look at to see how to use it? To find examples look for the pattern 'Dwarf::assemble" in gdb/testsuite/gdb.dwarf2/*.exp. The dwarf assembler does use include/dwarf.h and include/dwarf.def to build up the set of attributes and form types that are supported, so in that sense the basics of DWARF5 will be supported, but when you start to look at new sections, or new layouts for existing sections, then no, this is most likely not supported, yet. Thanks, Andrew > > -- Caroline > cmtice@google.com > > On Thu, Jul 16, 2020 at 1:12 PM Tom Tromey wrote: > > > > Joseph> On general free software and reproducible builds principles: > > Joseph> * The source for any checked-in object file should be checked in. > > Joseph> * That source should include comments giving all information required to > > Joseph> be able to reproduce the object file byte-for-byte > > > > In the past we tried this kind of thing, by taking the assembly > > generated by the compiler, then editing it and checking it in. > > > > However, IMO, this turned out to be a pain. The hand editing was often > > not sufficiently documented, and the tests were still > > architecture-dependent. Once or twice I think someone has had to edit > > the .S file later, which is error-prone. Also, the earliest test suite > > additions like this didn't include the original source, making this > > harder to handle. > > > > The "DWARF assembler" in the test suite avoids all this, at least for > > tests that require particular debuginfo. The main drawbacks of this > > approach are (again IMO) that sometimes it's a pain to write the DWARF > > by hand, and that sometimes the assembler framework itself needs > > upgrades before one can even begin. However, the tests are much more > > robust. > > > > I'd encourage the extension of the latter approach as much as possible. > > It isn't perfect but IME has been better on the whole. > > > > Tom