From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id 56CF33857C45 for ; Thu, 16 Jul 2020 18:47:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 56CF33857C45 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x443.google.com with SMTP id k6so8171256wrn.3 for ; Thu, 16 Jul 2020 11:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0ILtakePlsHABhwmQmtgbuisOacwg7wjCy6BF64z5Wk=; b=Zsv5jchjzQN60yw7xuAEza6QwCWh9ymyPxq4l+yVeTO6wN27d7OoAFJ1zZXPrN4KPC mvPTgNlN09ms2VQuI6GH05r+/LrVk2jNTqGvyiEr08Rey5cZOXO5LiSxBpzBLrM4zA80 mNtrAifXN4rSCzfNnQcjZdlFaGBXpJ9npKjyUb0IpUPeXxuQFjnowS1R63dvBma3F529 ZHkoTsLmvo8SVUMoksBG6lZKbx+0fGrua0eDILgjwiJHM7oqnYfgJrnmr8uRDmMXVDLc EeGvdMfpc/ZcURtW+ewCLicyLsKAEXU9+L0lyUBsY7lhS+BSt+bQvO/c7gtg/B24hoSg WBnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0ILtakePlsHABhwmQmtgbuisOacwg7wjCy6BF64z5Wk=; b=q+4UzJ1NJ1cck6e2PKHVXewojaog+TVWV1+4P8+oJSPPi/puMkwJdao1AMmOwTyY+z wOyQ4rPgmlp43ZuJ5KnEB0HXDd7elhwuysvaAqzg3RRpUjxBghfjcdN0lPKRYT0QwFee 7PUUYvUuD4rz5TCzcKxYDyfZnMWlJorI5r7xlkjzRuoNpyzopP5t55cYEG6/eu7yUMps ql9d4YEBwijCXqFw/caq00Q/XuPBhRo0jJ9L3YM3lD4XfX3QaHrdCS9C17Ww4xLrcFY/ 7dxIoOzbb9+PNM1VG+sogr7kcuweIBKrjONKl/IzkSCv379WQoySu6eaqHFTfQHFqeob pAdw== X-Gm-Message-State: AOAM5301LCdFVaz7GFA3UN1ur08X8pI/JAstfDUV162LvR5C6sk4SKZk Sh/nht6LflOPCesJFvYfMZ03ig== X-Google-Smtp-Source: ABdhPJwrz1BX/FyhzJNP/q9AOznKkjPkfFGubovMVkZ4HUnJXswx9GKNHxu2diB2Vc2+0u/WbehloA== X-Received: by 2002:a5d:608f:: with SMTP id w15mr6005738wrt.136.1594925262460; Thu, 16 Jul 2020 11:47:42 -0700 (PDT) Received: from localhost (host86-128-12-23.range86-128.btcentralplus.com. [86.128.12.23]) by smtp.gmail.com with ESMTPSA id l1sm11568260wrb.12.2020.07.16.11.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 11:47:41 -0700 (PDT) Date: Thu, 16 Jul 2020 19:47:40 +0100 From: Andrew Burgess To: Caroline Tice Cc: Joseph Myers , Eric Christopher , Simon Marchi , Tom Tromey , Caroline Tice via Gdb-patches Subject: Re: [PATCH] Update testsuite mechanism to allow object files as source files. Message-ID: <20200716184740.GI2737@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 19:46:13 up 38 days, 8:53, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 18:47:44 -0000 * Caroline Tice via Gdb-patches [2020-07-16 11:13:24 -0700]: > On Thu, Jul 16, 2020 at 10:33 AM Joseph Myers wrote: > > > > On Thu, 16 Jul 2020, Caroline Tice via Gdb-patches wrote: > > > > > High level summary: > > > In some (hopefully rare) cases, certain tests MUST be built with a > > > particular compiler to work. If that compiler is not GCC, then it > > > makes it very burdensome for developers to run the GDB testsuite and > > > test those tests. This change allows those tests to use object files > > > (generated by the required compiler) as the test source file, so that > > > when the test suite is run with GCC those tests will still > > > execute/test properly. > > > > How is this expected to work when the GDB being tested is configured for a > > different architecture or OS from that of the checked-in object file and > > may not be able to read its object file format at all? Will all such > > tests have explicit conditioning on the target for which GDB is > > configured? > > That is a very good point; I suppose this test should be marked to > only work on the architecture for which the test was compiled? (I know > I've seen those kinds of restrictions in testsuites before, although > I'm not sure if the GDB testsuite is currently set up for such > restrictions). Yes tests can be restricted for particular architectures, look for istarget checks throughout the testsuite, for example in: gdb/testsuite/gdb.arch/amd64-entry-value-param-dwarf5.exp Thanks, Andrew