From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 5D5563861902 for ; Mon, 13 Jul 2020 14:56:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D5563861902 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-DqciACtoMp2VzJPy30BSdA-1; Mon, 13 Jul 2020 10:56:24 -0400 X-MC-Unique: DqciACtoMp2VzJPy30BSdA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2556800400; Mon, 13 Jul 2020 14:56:23 +0000 (UTC) Received: from blade.nx (ovpn-114-254.ams2.redhat.com [10.36.114.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F92460E1C; Mon, 13 Jul 2020 14:56:23 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 59E3E816CCA9; Mon, 13 Jul 2020 15:56:22 +0100 (BST) Date: Mon, 13 Jul 2020 15:56:22 +0100 From: Gary Benson To: Simon Marchi Cc: Joel Brobecker , Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb: add linux_nat_debug_printf macro Message-ID: <20200713145622.GA25934@blade.nx> References: <20200702193034.22279-1-simon.marchi@efficios.com> <20200703173306.GA901@adacore.com> <20200710114757.GA2535@blade.nx> <580a486e-1efc-e0c1-70b1-e33fe4f7acac@simark.ca> <20200713143243.GK4914@adacore.com> <0ad0b987-cdca-a7a1-da8e-dafb5fac7e71@simark.ca> MIME-Version: 1.0 In-Reply-To: <0ad0b987-cdca-a7a1-da8e-dafb5fac7e71@simark.ca> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2020 14:56:32 -0000 Simon Marchi wrote: > On 2020-07-13 10:32 a.m., Joel Brobecker wrote: > > I skimmed through the patch, and it looked good to me. > > > > Thanks again for doing that. That's a nice improvement. > > > > Thinking out loud (and certainly not a suggestion or request that > > you take care of the implementation): I'm wondering if we should be > > thinking about generalizing this approach, somehow. For instance, > > if we a function that took not just a func name, but also the name > > of the unit: > > > > unit_debug_vprintf (const char *module_name, const char *func_name, > > const char *fmt, ...) > > > > ... or perhaps more generally: > > > > unit_debug_vprintf (const char *label, const char *func_name, > > const char *fmt, ...) > > > > ... then all modules would have to do to have consistent logging > > is to define one macro. > > Yes, if people like the format I'd be open to changing other > "modules" to use it, and having a generic function to ensure the > same formatting is used everywhere would be the logical thing to do. I like it :) Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat