Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: Luis Machado <luis.machado@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Skip VLA structure field tests when compiling with clang
Date: Mon, 13 Jul 2020 14:49:33 +0100	[thread overview]
Message-ID: <20200713134933.GA17938@blade.nx> (raw)
In-Reply-To: <fbf90df4-ad98-62ad-2cae-8726e1b62bde@palves.net>

Pedro Alves wrote:
> On 7/10/20 1:00 PM, Gary Benson via Gdb-patches wrote:
> > > > +# Clang says it will never support variable length arrays in structures.
> > > > +if {[test_compiler_info clang*]} {
> > > > +    unsupported "compiler does not variable length arrays in structure"
> > >
> > >                                       ^^^ support?
> > >
> > > Otherwise this looks good to me. Can't approve a commit though.
> > 
> > Good catch.  Thanks for your review, I've fixed this in my tree.
> 
> This is OK with that fixed.

Thanks, I've pushed it.

Cheers,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat



      reply	other threads:[~2020-07-13 13:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 11:12 [PATCH] " Gary Benson
2020-06-30 17:25 ` Luis Machado
2020-07-08 15:46   ` [PATCH v2] " Gary Benson
2020-07-09 16:44     ` Luis Machado
2020-07-10 12:00       ` Gary Benson
2020-07-10 14:31         ` Pedro Alves
2020-07-13 13:49           ` Gary Benson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713134933.GA17938@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox